Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa): Allowed properties expand #4600

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Jul 25, 2023

What:
The expand allowed properties should allow all the segments whereas the allowed fields should be specific

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

🦋 Changeset detected

Latest commit: 37afb8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Jul 25, 2023 2:10pm

@adrien2p adrien2p marked this pull request as ready for review July 25, 2023 08:28
@adrien2p adrien2p requested a review from a team as a code owner July 25, 2023 08:28
@adrien2p
Copy link
Member Author

/snapshot-this

@adrien2p adrien2p changed the title fix(medusa): Clean response data should takes the full path of sub relations fix(medusa): Allowed properties expand Jul 25, 2023
@adrien2p
Copy link
Member Author

/snapshot-this

@olivermrbl
Copy link
Contributor

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: ae33f48

olivermrbl
olivermrbl previously approved these changes Jul 25, 2023
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl dismissed their stale review July 25, 2023 11:14

Tests not passing

@adrien2p
Copy link
Member Author

@olivermrbl anything else?

@kodiakhq kodiakhq bot merged commit 9129ca0 into develop Jul 25, 2023
@kodiakhq kodiakhq bot deleted the fix/clean-response-data-fields branch July 25, 2023 14:37
@github-actions github-actions bot mentioned this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants