Fix: Make total of cart minus any discounts gift cardable

[Arsenalist]

This updates the gift cardable amount to equal the total of the cart minus any discounts.

When the order is created from the cart, the existing logic works fine and applies the gift card to the whole amount. It is only when displaying the cart where the amount isn't being applied to all the totals in the cart.

Customers who are applying gift card expect the card to cover all balances since gift cards are a form of payment.

[changeset-bot]

⚠️ No Changeset found

Latest commit: e761e11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

@Arsenalist is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

[Arsenalist]

Can I please get some feedback on whether this can be merged? This is my first contribution so I don’t know if I’m following the right process. Apologies if I am not. @chemicalkosek @adrien2p

[Arsenalist]

Anyone able to comment on this?

[adrien2p]

@Arsenalist Thanks for the pr, we will have a look and discuss about it, I just want to be sure the changes are the right one

[Arsenalist]

@Arsenalist Thanks for the pr, we will have a look and discuss about it, I just want to be sure the changes are the right one

Hi, is there an ETA when this could be potentially merged? I'm ready to release gift cards to my customers but don't want to have the cart showing the wrong information (even though the order part works as expected).

[adrien2p]

I ve open a more complete pr here #5075 and we just need to discuss it to be sure se don't introduce any unforeseen bug and then we will merge it.

[riqwan]

Hey, thanks for the PR! Since v2 brought a lot of architectural changes, we will be closing this PR since it no longer applies to our new setup.

If you would still like to open this PR, please rebase with the v1 branch and re-request a review & we'll get back on it quickly.