fix(medusa): totals calculation with gift card

[adrien2p]

What
Resolve potential discrepency between what is calculated in the createFromCart and the cart/order totals calculation.
When the giftCard is taxable then the following calculation is applied

cart.subtotal + cart.shipping_total - cart.discount_total

otherwise

 cart.subtotal +
          cart.shipping_total +
          cart.tax_total -
          cart.discount_total

[changeset-bot]

🦋 Changeset detected

Latest commit: 8f913fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@medusajs/medusa	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)	Visit Preview		Oct 25, 2023 10:16am
docs-ui	⬜️ Ignored (Inspect)	Visit Preview		Oct 25, 2023 10:16am
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 25, 2023 10:16am

[adrien2p]

@olivermrbl let me know when we can discuss that pr

[olivermrbl]

@olivermrbl let me know when we can discuss that pr

Can you add a short description of what changes are introduced in this PR?

[Arsenalist]

Is there any feedback on this change or can we merge it?

[Arsenalist]

I would just like to know if this will be merged or not, or if I have to fork Medusa or not.

[olivermrbl]

Looks like we need to update a couple of tests before we can merge

[adrien2p]

@olivermrbl should we move this one?