Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Rename userpass #6251

Conversation

pKorsholm
Copy link
Contributor

What

  • rename usernamePassword to userpass

@pKorsholm pKorsholm requested review from a team as code owners January 29, 2024 03:16
Copy link

changeset-bot bot commented Jan 29, 2024

⚠️ No Changeset found

Latest commit: c1da548

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 8:50am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 29, 2024 8:50am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 8:50am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 8:50am

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought(very-nit): Would it be more appropriate to call this emailpass? I know we use email as the username, so the name makes sense. However, one could imagine a different provider using handle (e.g. GH, Discord, etc.) as username. In that case, it would be handlepass (or something similar).

@pKorsholm
Copy link
Contributor Author

sure thing! emailpass makes sense

@pKorsholm pKorsholm merged commit b3b027f into feat/rename-authentication-to-auth Jan 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants