Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-flow, medusa): Create cart with Sales Channel #6427

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

olivermrbl
Copy link
Contributor

What

  • Add findSalesChannelStep to CreateCartWorkflow. There are a couple of todos:
    • Find default sales channel configured on the store
    • Implement publishable API key work
  • Parallelize the data populating steps in CreateCartWorkflow

@olivermrbl olivermrbl requested review from a team as code owners February 18, 2024 15:30
Copy link

changeset-bot bot commented Feb 18, 2024

⚠️ No Changeset found

Latest commit: bd02f01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 7:33am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 19, 2024 7:33am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 7:33am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 7:33am

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although think we should move sales channel resolution from a publishable key out of the workflow and into the API layer instead. We can revisit this when the API key module is done.

Base automatically changed from feat/create-cart-with-customer to develop February 19, 2024 07:28
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl olivermrbl merged commit 680dfcd into develop Feb 19, 2024
17 checks passed
@olivermrbl olivermrbl deleted the feat/create-cart-with-sc branch February 19, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants