- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core-flow, medusa): Create cart with Sales Channel #6427
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - although think we should move sales channel resolution from a publishable key out of the workflow and into the API layer instead. We can revisit this when the API key module is done.
packages/core-flows/src/definition/cart/steps/find-sales-channel.ts
Outdated
Show resolved
Hide resolved
0e4fea0
to
bd02f01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What
findSalesChannelStep
toCreateCartWorkflow
. There are a couple of todos:CreateCartWorkflow