Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-flow, medusa): Create cart with Sales Channel #6427

Merged
merged 2 commits into from
Feb 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions integration-tests/plugins/__tests__/cart/store/carts.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,21 @@ describe("Store Carts API", () => {
).rejects.toThrow()
})

it("should throw if sales channel is disabled", async () => {
const api = useApi() as any

const salesChannel = await scModuleService.create({
name: "Webshop",
is_disabled: true,
})

await expect(
api.post(`/store/carts`, {
sales_channel_id: salesChannel.id,
})
).rejects.toThrow()
})

describe("compensation", () => {
it("should delete created customer if cart-creation fails", async () => {
expect.assertions(2)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import { ModuleRegistrationName } from "@medusajs/modules-sdk"
import { ISalesChannelModuleService, SalesChannelDTO } from "@medusajs/types"
import { MedusaError } from "@medusajs/utils"
import { StepResponse, createStep } from "@medusajs/workflows-sdk"

interface StepInput {
salesChannelId?: string
}

export const findSalesChannelStepId = "find-sales-channel"
export const findSalesChannelStep = createStep(
findSalesChannelStepId,
async (data: StepInput, { container }) => {
const salesChannelService = container.resolve<ISalesChannelModuleService>(
ModuleRegistrationName.SALES_CHANNEL
)

let salesChannel: SalesChannelDTO | undefined
if (data.salesChannelId) {
salesChannel = await salesChannelService.retrieve(data.salesChannelId)
} else {
// TODO: Find default sales channel from store
}

if (salesChannel?.is_disabled) {
throw new MedusaError(
MedusaError.Types.INVALID_DATA,
`Unable to assign cart to disabled Sales Channel: ${salesChannel.name}`
)
}

return new StepResponse(salesChannel)
}
)
2 changes: 1 addition & 1 deletion packages/core-flows/src/definition/cart/steps/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export * from "./create-carts"
export * from "./find-one-or-any-region"
export * from "./find-or-create-customer"
export * from "./find-sales-channel"
export * from "./update-carts"

57 changes: 35 additions & 22 deletions packages/core-flows/src/definition/cart/workflows/create-carts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,41 +2,54 @@ import { CartDTO, CreateCartWorkflowInputDTO } from "@medusajs/types"
import {
WorkflowData,
createWorkflow,
parallelize,
transform,
} from "@medusajs/workflows-sdk"
import {
createCartsStep,
findOneOrAnyRegionStep,
findOrCreateCustomerStep,
findSalesChannelStep,
} from "../steps"

export const createCartWorkflowId = "create-cart"
export const createCartWorkflow = createWorkflow(
createCartWorkflowId,
(input: WorkflowData<CreateCartWorkflowInputDTO>): WorkflowData<CartDTO> => {
const region = findOneOrAnyRegionStep({
regionId: input.region_id,
})

const customerData = findOrCreateCustomerStep({
customerId: input.customer_id,
email: input.email,
})

const cartInput = transform({ input, region, customerData }, (data) => {
const data_ = {
...data.input,
currency_code: data.input.currency_code ?? data.region.currency_code,
region_id: data.region.id,
const [salesChannel, region, customerData] = parallelize(
findSalesChannelStep({
salesChannelId: input.sales_channel_id,
}),
findOneOrAnyRegionStep({
regionId: input.region_id,
}),
findOrCreateCustomerStep({
customerId: input.customer_id,
email: input.email,
})
)

const cartInput = transform(
{ input, region, customerData, salesChannel },
(data) => {
const data_ = {
...data.input,
currency_code: data.input.currency_code ?? data.region.currency_code,
region_id: data.region.id,
}

if (data.customerData.customer?.id) {
data_.customer_id = data.customerData.customer.id
data_.email = data.input?.email ?? data.customerData.customer.email
}

if (data.salesChannel?.id) {
data_.sales_channel_id = data.salesChannel.id
}

return data_
}

if (data.customerData.customer?.id) {
data_.customer_id = data.customerData.customer.id
data_.email = data.input?.email ?? data.customerData.customer.email
}

return data_
})
)

// TODO: Add line items

Expand Down
4 changes: 2 additions & 2 deletions packages/medusa/src/api-v2/middlewares.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ import { MiddlewaresConfig } from "../loaders/helpers/routing/types"
import { adminCampaignRoutesMiddlewares } from "./admin/campaigns/middlewares"
import { adminCustomerGroupRoutesMiddlewares } from "./admin/customer-groups/middlewares"
import { adminCustomerRoutesMiddlewares } from "./admin/customers/middlewares"
import { adminInviteRoutesMiddlewares } from "./admin/invites/middlewares"
import { adminPromotionRoutesMiddlewares } from "./admin/promotions/middlewares"
import { adminRegionRoutesMiddlewares } from "./admin/regions/middlewares"
import { adminUserRoutesMiddlewares } from "./admin/users/middlewares"
import { adminWorkflowsExecutionsMiddlewares } from "./admin/workflows-executions/middlewares"
import { authRoutesMiddlewares } from "./auth/middlewares"
import { storeCartRoutesMiddlewares } from "./store/carts/middlewares"
import { storeCustomerRoutesMiddlewares } from "./store/customers/middlewares"
import { adminUserRoutesMiddlewares } from "./admin/users/middlewares"
import { storeRegionRoutesMiddlewares } from "./store/regions/middlewares"
import { adminInviteRoutesMiddlewares } from "./admin/invites/middlewares"

export const config: MiddlewaresConfig = {
routes: [
Expand Down
Loading