feat(core-flows): Use remote link methods to dismiss all links related to inventory item

[pKorsholm]

What

• use remoteLink.delete to dismiss all connections to inventory_item_id

[changeset-bot]

⚠️ No Changeset found

Latest commit: b9d2e37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medusa-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 22, 2024 9:46am

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)			Mar 22, 2024 9:46am
docs-ui	⬜️ Ignored (Inspect)	Visit Preview		Mar 22, 2024 9:46am
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview		Mar 22, 2024 9:46am

[carlos-r-l-rodrigues]

I think we can rename that file and the step to refer to deletion as well, because in theory you can still have a place where you just want to call a detach and that would be your current step.

[adrien2p]

Should we also check that the link configurations include the cascade option?

Cc @carlos-r-l-rodrigues

[adrien2p]

Do we have tests to validate the deletions of the links with multiple levels or links?

[riqwan]

one suggestion, but lgtm!

[riqwan]

oh cool, didn't know this does a soft delete. Would be good to have a test that checks this.

[riqwan]

suggestion: don't have to do this now, but I wonder if we can do a generic deleteLinkStep() that accepts an object. Something like this:

deleteLinkStep({
  [Modules.INVENTORY]: { inventory_item_id: data.ids },
})

[carlos-r-l-rodrigues]

https://github.com/medusajs/medusa/blob/94208a979bb14a6bbbb4ea5ba8f712a7068917df/packages/core-flows/src/common/steps/remove-remote-links.ts

if needed you can bring this one to the PR

[riqwan]

nice!

[olivermrbl]

@carlos-r-l-rodrigues very nice!

[carlos-r-l-rodrigues]

Should we also check that the link configurations include the cascade option?

Cc @carlos-r-l-rodrigues

Yeah, I think so. But I'm not sure if we have one yet. Maybe the link between product variant and inventory item?

[adrien2p]

Should we also check that the link configurations include the cascade option?
Cc @carlos-r-l-rodrigues

Yeah, I think so. But I'm not sure if we have one yet. Maybe the link between product variant and inventory item?

Yeah something like that, or cart -> sales_channel -> fulfillment too