Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-flows): Use remote link methods to dismiss all links related to inventory item #6737

Merged
merged 6 commits into from
Mar 22, 2024
Merged

feat(core-flows): Use remote link methods to dismiss all links related to inventory item #6737

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26f70ad
use remote link methods to dismiss all links related to inventory item
pKorsholm Mar 19, 2024
cd51877
Merge branch 'develop' into feat/use-link-module-delete-for-deatach
pKorsholm Mar 20, 2024
13e05d1
Merge branch 'develop' into feat/use-link-module-delete-for-deatach
pKorsholm Mar 21, 2024
4167c02
use remove remote links common step
pKorsholm Mar 21, 2024
766d0ab
Merge branch 'develop' into feat/use-link-module-delete-for-deatach
pKorsholm Mar 21, 2024
b9d2e37
Merge branch 'develop' into feat/use-link-module-delete-for-deatach
pKorsholm Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 9 additions & 35 deletions packages/core-flows/src/inventory/steps/deatach-inventory-items.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,47 +13,21 @@ export const deatachInventoryItemStep = createStep(
async (ids: string[], { container }) => {
const remoteLink = container.resolve(ContainerRegistrationKeys.REMOTE_LINK)

const linkModule: ILinkModule = remoteLink.getLinkModule(
Modules.PRODUCT,
"variant_id",
Modules.INVENTORY,
"inventory_item_id"
)
await remoteLink.delete({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh cool, didn't know this does a soft delete. Would be good to have a test that checks this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: don't have to do this now, but I wonder if we can do a generic deleteLinkStep() that accepts an object. Something like this:

deleteLinkStep({
  [Modules.INVENTORY]: { inventory_item_id: data.ids },
})

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/medusajs/medusa/blob/94208a979bb14a6bbbb4ea5ba8f712a7068917df/packages/core-flows/src/common/steps/remove-remote-links.ts

if needed you can bring this one to the PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-r-l-rodrigues very nice!

[Modules.INVENTORY]: { inventory_item_id: ids },
})

const links = (await linkModule.list(
{ inventory_item_id: ids },
{ select: ["variant_id", "inventory_item_id"] }
)) as { inventory_item_id: string; variant_id: string }[]

await remoteLink.dismiss(
links.map(({ inventory_item_id, variant_id }) => ({
[Modules.PRODUCT]: {
variant_id,
},
[Modules.INVENTORY]: {
inventory_item_id,
},
}))
)

return new StepResponse(void 0, links)
return new StepResponse(void 0, ids)
},
async (input, { container }) => {
if (!input?.length) {
async (deatachedInventoryIds, { container }) => {
if (!deatachedInventoryIds?.length) {
return
}

const remoteLink = container.resolve(ContainerRegistrationKeys.REMOTE_LINK)

const linkDefinitions = input.map(({ inventory_item_id, variant_id }) => ({
[Modules.PRODUCT]: {
variant_id,
},
[Modules.INVENTORY]: {
inventory_item_id,
},
}))

const links = await remoteLink.create(linkDefinitions)
await remoteLink.restore({
[Modules.INVENTORY]: { inventory_item_id: deatachedInventoryIds },
})
}
)
Loading