Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German: Adds some more test cases and updates dictionary #306

Merged
merged 1 commit into from
Sep 12, 2024
Merged

German: Adds some more test cases and updates dictionary #306

merged 1 commit into from
Sep 12, 2024

Conversation

luflow
Copy link
Contributor

@luflow luflow commented Sep 10, 2024

Pull Request

What does this PR do?

  • Updating the german dictionary and some settings tweaks

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@luflow luflow force-pushed the fix/german-dictionary-and-settings branch 3 times, most recently from 8e02fff to e1436dc Compare September 10, 2024 21:20
@luflow luflow force-pushed the fix/german-dictionary-and-settings branch from e1436dc to aad5073 Compare September 10, 2024 21:22
ManyTheFish
ManyTheFish approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some relevancy improvement i see,
may we merge this?

@luflow
Copy link
Contributor Author

luflow commented Sep 11, 2024

@ManyTheFish sure, ready to merge! :) just some issues of the old PR we found with the team looking at it again ;)

@ManyTheFish
Copy link
Member

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Sep 12, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 7227b3c into meilisearch:main Sep 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManyTheFish ManyTheFish ManyTheFish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luflow @ManyTheFish