Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German: Adds some more test cases and updates dictionary #306

Merged
merged 1 commit into from
Sep 12, 2024
Merged

German: Adds some more test cases and updates dictionary #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified charabia/dictionaries/fst/german/words.fst
View file
Open in desktop
Binary file not shown.
6 changes: 4 additions & 2 deletions charabia/dictionaries/txt/german/words.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6192,7 +6192,7 @@ Glas
Glaser
Glasnost
Glasur
Glatteis
Glatt
Glatze
Glaube
Glauben
Expand Down Expand Up @@ -8306,6 +8306,7 @@ Kuli
Kulisse
Kult
Kultur
Kulturalität
Kultus
Kummer
Kumpan
Expand Down Expand Up @@ -21691,7 +21692,7 @@ glas
glaser
glasnost
glasur
glatteis
glatt
glatze
glaube
glauben
Expand Down Expand Up @@ -23805,6 +23806,7 @@ kuli
kulisse
kult
kultur
kulturalität
kultus
kummer
kumpan
Expand Down
31 changes: 29 additions & 2 deletions charabia/src/segmenter/german.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ static WORDS_FST: Lazy<Fst<&[u8]>> =
Lazy::new(|| Fst::new(&include_bytes!("../../dictionaries/fst/german/words.fst")[..]).unwrap());

static FST_SEGMENTER: Lazy<FstSegmenter> =
Lazy::new(|| FstSegmenter::new(&WORDS_FST, Some(4), true));
Lazy::new(|| FstSegmenter::new(&WORDS_FST, Some(2), true));

impl Segmenter for GermanSegmenter {
fn segment_str<'o>(&self, to_segment: &'o str) -> Box<dyn Iterator<Item = &'o str> + 'o> {
Expand Down Expand Up @@ -100,7 +100,34 @@ mod test {
word1
);
test_segmentation!("Schreibprozess", &["Schreib", "prozess"], word2);
test_segmentation!("Interkulturalität", &["Inter", "kultur", "alität"], word3);
test_segmentation!("Interkulturalität", &["Inter", "kulturalität"], word3);
test_segmentation!("Wissensorganisation", &["Wissens", "organisation"], word4);
test_segmentation!("Aufgabenplanung", &["Aufgaben", "planung"], word5);
test_segmentation!("Eisbrecher", &["Eis", "brecher"], word6);
test_segmentation!("Zuckerei", &["Zucker", "ei"], word7);
test_segmentation!("Glatteis", &["Glatt", "eis"], word8);
test_segmentation!("Sinnfindung", &["Sinn", "findung"], word9);
test_segmentation!(
"Donaudampfschifffahrtsgesellschaftskapitän",
&["Donau", "dampf", "schifffahrts", "gesellschafts", "kapitän"],
word10
);
test_segmentation!(
"Rindfleischetikettierungsüberwachungsaufgabenübertragungsgesetz",
&[
"Rind",
"fleisch",
"etikettierungs",
"überwachungs",
"aufgaben",
"übertragungs",
"gesetz"
],
word11
);
test_segmentation!(
"Nahrungsmittelunverträglichkeitsdiagnoseverfahren",
&["Nahrungs", "mittel", "un", "verträglichkeits", "diagnose", "verfahren"],
word12
);
}
Loading