frr-k8s: deploy webhook upfront #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oribon
force-pushed
the
separate_frrk8swebhook
branch
8 times, most recently
from
186d836 to
110b92b
Compare
Similarly to MetalLB, we deploy the webhook upfront to allow creating FRRConfigurations before frr-k8s is deployed. Signed-off-by: Ori Braunshtein <[email protected]>
oribon
force-pushed
the
separate_frrk8swebhook
branch
from
110b92b to
73ea0ce
Compare
|
We decided to close this for now until we make this mode default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to MetalLB, we deploy the webhook upfront to allow creating FRRConfigurations before frr-k8s is deployed.
#404 (comment)