frr-k8s: relabel metrics #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumping to the latest version, this is specifically to consume a later version of frr-k8s where metricRelabelings are supported. Signed-off-by: Ori Braunshtein <[email protected]>
We deploy the serviceMonitors of frr-k8s so that the scraped metrics show as MetalLB's, making the integration cleaner. Signed-off-by: Ori Braunshtein <[email protected]>
|
lgtm |
We run the frr-k8s webhooks e2es before running MetalLB's to ensure the webhook was deployed correctly. This also adds a missing skip to the publish lane, and to the MetalLB-E2E lane because of the commit bump. Signed-off-by: Ori Braunshtein <[email protected]>
oribon
force-pushed
the
frrk8s_metricrelabel
branch
from
447182f to
23b07cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We deploy the serviceMonitors of frr-k8s so that the scraped
metrics show as MetalLB's, making the integration cleaner.