Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(URGENT) CIPM Declaration from CIPM meeting 90 shows mistaken # character in title #264

Closed
ronaldtse opened this issue Dec 18, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Dec 18, 2024

As you can see there is an issue with a # inserted into the declaration's description here:
Screenshot 2024-12-18 at 8 34 10 PM

The particular line originates from here:

Then in relaton-data-bipm here:

And it seems that it is actually a normal white space, so I don't know why it became a # (which typically indicates a missing glyph).

Ping @Intelligent2013 @andrew2net to fix this.

Originally posted by @ronaldtse in #223 (comment)

@ronaldtse ronaldtse changed the title CIPM Declaration from CIPM meeting 90 shows mistaken # character in title (URGENT) CIPM Declaration from CIPM meeting 90 shows mistaken # character in title Dec 18, 2024
@ronaldtse ronaldtse added the bug Something isn't working label Dec 18, 2024
@ronaldtse ronaldtse moved this to 🌋 Urgent in Metanorma Dec 18, 2024
@andrew2net
Copy link
Contributor

@ronaldtse there is no "#" in relaton-data-bipm, right? So we need to check renderer.

@ronaldtse
Copy link
Contributor Author

Yes it seems like a rendering problem. However can you help double check that the space in your data is a normal space? Thanks.

@andrew2net
Copy link
Contributor

Just checked, they are normal 32 code space

@Intelligent2013
Copy link
Contributor

In the PDF generated on my machine (Win10) there isn't #:
image

The font Times New Roman Italic is using for the text rendering:
image

The difference between your and my PDF means that some 'space' character is missing in your font instance (may be old). Some years we have the similar issues. If you need I can find, but in any case the new font should be used.

In the Presentation XML there are two spaces between «  and unités :

  • space 0x202F Narrow No-Break Space
  • space 0x20

image

image

My Times New Roman font instance contains 0x202F character:
image

In the semantic XML only one space:
image

In meeting-90.yml and 2001-00.yaml only one space 0x20:
image

@opoudjis could you take a look at the reason why 0x202F appears in the Presentation XML?

@andrew2net
Copy link
Contributor

@ronaldtse maybe the problem is not in spaces. The "«" is not an UTF-8 symbol

>  "« unités SI » et « unités du SI »"[0].ord
=> 171

> 171.chr
 => "\xAB"

> puts 171.chr
(irb):190:in `write': "\xAB" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)

@opoudjis
Copy link
Contributor

The additional space is my fault. I am applying French punctuation rules to generated references, which is appropriate, but I should not be inserting spaces after gullemets, if spaces are already there, even if they are the "wrong" space (normal space instead of the correct 202f.) Needs fix to isodoc-i18n, will do hotfix shortly.

@opoudjis
Copy link
Contributor

tested with * [[[PV57_5, CIPM RES (1948, F)]]]: I'm currently unable to fetch * [[[PV69, CIPM Declaration (2001)]]]. Confirmed that it is no longer inserting extra 202f:

<bibitem id="PV57_5" type="proceedings" schema-version="v1.2.9">
<formattedref>Comité International des Poids et Mesures (1948) 
<em>Adoption de « degré Celsius »</em> (Paris : Bureau international des poids et mesures) 

@manuelfuenmayor
Copy link
Contributor

Fix confirmed:
fix-ref

@github-project-automation github-project-automation bot moved this from 🌋 Urgent to ✅ Done in Metanorma Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants