add OGC abbreviation to metadata, refactor organisation contributor m… #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| return unless node.attr("committee") | ||
| def org_abbrev | ||
| { "Open Geospatial Consortium" => "OGC" } | ||
| end |
There was a problem hiding this comment.
end at 84, 6 is not aligned with def at 82, 7.
| end | ||
|
|
||
| def metadata_committee(node, xml) | ||
| return unless node.attr("committee") | ||
| def org_abbrev |
There was a problem hiding this comment.
Use 2 (not 3) spaces for indentation.
Inconsistent indentation detected.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
==========================================
+ Coverage 93.62% 93.63% +0.01%
==========================================
Files 22 22
Lines 1004 1006 +2
==========================================
+ Hits 940 942 +2
Misses 64 64 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etadata: https://github.com/metanorma/metanorma-nist/issues/103
Metanorma PR checklist