logo attributes, organisation attributes overhaul: https://github.com… #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| end | ||
|
|
||
| def org_address(node, person) | ||
| node.attr("pub-address") and person.address do |ad| | ||
| def org_address(org, xml) |
There was a problem hiding this comment.
Assignment Branch Condition size for org_address is too high. [<7, 13, 5> 15.59/15]
| end | ||
| end | ||
|
|
||
| def organization(org, orgname, is_pub, node = nil, default_org = nil) | ||
| def organization(org, orgname, node = nil, default_org = nil) |
There was a problem hiding this comment.
Cyclomatic complexity for organization is too high. [7/6]
| OUTPUT | ||
| expect(xmlpp(strip_guid(Asciidoctor.convert(input, *OPTIONS)))) | ||
| .to be_equivalent_to xmlpp(output) | ||
| end | ||
|
|
||
| it "processes formatted address overridding address components" do | ||
| it "processes formatted address overridding address components; publisher attributes" do |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #831 +/- ##
=======================================
Coverage 96.60% 96.61%
=======================================
Files 64 64
Lines 5248 5291 +43
=======================================
+ Hits 5070 5112 +42
- Misses 178 179 +1 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 23, 2023
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/metanorma/metanorma-nist/issues/103
Metanorma PR checklist