[MTG-237] ci cd #17

rwwwx · 2024-07-09T15:57:07Z

No description provided.

kstepanovdev · 2024-07-10T10:57:48Z

.cargo/audit.toml

+deny = [] # exit on error if unmaintained dependencies are found
+format = "terminal" # "terminal" (human-readable report) or "json"
+quiet = true # Only print information on error
+show_tree = false # Show inverse dependency trees along with advisories (default: true)


Add a newline everywhere (you might want to do this as a default setting on a file save, just like cargo fmt)

kstepanovdev · 2024-07-10T10:58:59Z

.cargo/audit.toml

@@ -0,0 +1,8 @@
+[advisories]
+ignore = ["RUSTSEC-2024-0344", "RUSTSEC-2022-0093"] # ignore unfixable vulnerabilities


It's not an error, but why those two specifically?

Nvm, I have seen a comment. Why are they unfixable though?

I'm also curious.
Probably that's because of solana-ed25519-dalek dependency in solana itself. The fix in the library had been merged 3 weeks ago, so I assume the issue should gone soon in the next versions.

kstepanovdev · 2024-07-10T11:00:49Z

.github/workflows/ci-cargo-audit.yml

+on:
+  push:
+    branches:
+      - master


Our main branch is main I suppose

StanChe

Great job. Those unfixables are for solana to upgrade their libs, so we'd better change the comment and watch out when those may be fixed.

StanChe · 2024-07-10T11:02:28Z

.cargo/audit.toml

+deny = [] # exit on error if unmaintained dependencies are found
+format = "terminal" # "terminal" (human-readable report) or "json"
+quiet = true # Only print information on error
+show_tree = false # Show inverse dependency trees along with advisories (default: true)


Why not showing the tree? it might be helpful to understand what should we update?

As for me it was very noisy, so I thought it would be nice to remove this tree. But if you think different I will change it.

snorochevskiy · 2024-07-10T11:58:54Z

.cargo/audit.toml

@@ -0,0 +1,8 @@
+[advisories]
+ignore = ["RUSTSEC-2024-0344", "RUSTSEC-2022-0093"] # ignore unfixable vulnerabilities


I'm also curious.
Probably that's because of solana-ed25519-dalek dependency in solana itself. The fix in the library had been merged 3 weeks ago, so I assume the issue should gone soon in the next versions.

kstepanovdev

good job!

fixed CI/CD, added README.md and cargo audit

* initial design * fix tests for delegated initial design * Extend extend_stake instruction with delegate parameter Extend deposit_mining instruction with delegate parameter * Refactor and make arithmetic operations more readable * Add tests for delegated staking * minor fix * [MTG-237] ci cd (#17) fixed CI/CD, added README.md and cargo audit * Change ordering for PartialOrd and Ord for LockupPeriod * refactor * refactor asserts * remove redundant substraction from delegated stake check * Forbid mining account from closing if it has stake_from_others * remove useless comment * add delegate_mining field to the withdraw_mining && remove verification for weighted stake since it's done on the staking contract * initial design * fix tests for delegated initial design * Extend extend_stake instruction with delegate parameter Extend deposit_mining instruction with delegate parameter * Refactor and make arithmetic operations more readable * Add tests for delegated staking * Change ordering for PartialOrd and Ord for LockupPeriod * refactor * refactor asserts * remove redundant substraction from delegated stake check * Forbid mining account from closing if it has stake_from_others * remove useless comment * add delegate_mining field to the withdraw_mining && remove verification for weighted stake since it's done on the staking contract * remove useless imports * add more packing on closing account * update tests * remove redundant packing * [mtg-308] (#24) * add change delegate function * change_delegate: add an early return for the case when new_delegate_mining and old_delegate_mining are the same * satisfy clippy * [mtg-297] add stake_from_others for rewards calculations (#26) * add change delegate function * change_delegate: add an early return for the case when new_delegate_mining and old_delegate_mining are the same * satisfy clippy * add stake_from_others for rewards calculations * satisfy clippy * update tests && rebase * Add refreshing of rewards for delegate mining each time it's stake_from_others changes * Update programs/rewards/src/instruction.rs Co-authored-by: Stanislav Cherviakov <[email protected]> * minor fix after merge commit --------- Co-authored-by: Stanislav Cherviakov <[email protected]> --------- Co-authored-by: Matiukhin Vlad <[email protected]> Co-authored-by: Stanislav Cherviakov <[email protected]>

* rename RestakeDeposit to ExtendStake * add days lockup days to Flex * imporove uninitialize assertion * rename RewardPool:fill to RewardPool:distribute * from now fill cannot be invoked if rewards equals to zero * refactor DistributeRewards::process * refactor withdraw_mining * add fn for mining account closing * deposit_authority don't have to be mutable in close_mining ix * use more clear variable for RewardCalculator::update_index * regenerate IDL and clients * Initialize rewards-pool deposit authority signature (#15) * Initialize rewards-pool deposit authority signature * fixed comments and fmt * Throw an error instead of returning Ok() when 'rewards == 0' * removed elvis operator * [MTG-237] ci cd (#17) fixed CI/CD, added README.md and cargo audit * Fix comment in instruction.rs * Forbid closing mininig if there are pending rewards * Add comment regarding closing accounts * Unify Contexts && verification checks (#21) Unify Contexts and verification checks * mtg-425: Error handling improvements (#22) improved error handling * Threw an error if `weighted_stake_diffs.entry()` is empty (#25) Threw an error if `weighted_stake_diffs.entry()` is empty * [Mtg-296] delegated staking extend staking with delegate parameter (#18) * initial design * fix tests for delegated initial design * Extend extend_stake instruction with delegate parameter Extend deposit_mining instruction with delegate parameter * Refactor and make arithmetic operations more readable * Add tests for delegated staking * minor fix * [MTG-237] ci cd (#17) fixed CI/CD, added README.md and cargo audit * Change ordering for PartialOrd and Ord for LockupPeriod * refactor * refactor asserts * remove redundant substraction from delegated stake check * Forbid mining account from closing if it has stake_from_others * remove useless comment * add delegate_mining field to the withdraw_mining && remove verification for weighted stake since it's done on the staking contract * initial design * fix tests for delegated initial design * Extend extend_stake instruction with delegate parameter Extend deposit_mining instruction with delegate parameter * Refactor and make arithmetic operations more readable * Add tests for delegated staking * Change ordering for PartialOrd and Ord for LockupPeriod * refactor * refactor asserts * remove redundant substraction from delegated stake check * Forbid mining account from closing if it has stake_from_others * remove useless comment * add delegate_mining field to the withdraw_mining && remove verification for weighted stake since it's done on the staking contract * remove useless imports * add more packing on closing account * update tests * remove redundant packing * [mtg-308] (#24) * add change delegate function * change_delegate: add an early return for the case when new_delegate_mining and old_delegate_mining are the same * satisfy clippy * [mtg-297] add stake_from_others for rewards calculations (#26) * add change delegate function * change_delegate: add an early return for the case when new_delegate_mining and old_delegate_mining are the same * satisfy clippy * add stake_from_others for rewards calculations * satisfy clippy * update tests && rebase * Add refreshing of rewards for delegate mining each time it's stake_from_others changes * Update programs/rewards/src/instruction.rs Co-authored-by: Stanislav Cherviakov <[email protected]> * minor fix after merge commit --------- Co-authored-by: Stanislav Cherviakov <[email protected]> --------- Co-authored-by: Matiukhin Vlad <[email protected]> Co-authored-by: Stanislav Cherviakov <[email protected]> --------- Co-authored-by: Kyrylo Stepanov <[email protected]> Co-authored-by: Matiukhin Vlad <[email protected]> Co-authored-by: rwwwx <[email protected]>

CI/CD fix

28ab8bd

rwwwx changed the base branch from main to refactor-and-bugfixing July 9, 2024 15:57

rwwwx added 4 commits July 9, 2024 19:00

split solana-install and solana-install

7ee796f

formating and Switch toolchain fix

e056d6c

fixed linter warnings

5526d71

cargo audit test

0eff05e

StanChe changed the title ~~Mgt 237 ci cd~~ [MTG-237] ci cd Jul 10, 2024

rwwwx added 2 commits July 10, 2024 13:39

added audit.toml file

dfe3663

make audit output human-readable

7e759c1

kstepanovdev reviewed Jul 10, 2024

View reviewed changes

.github/workflows/ci-cargo-audit.yml Outdated

on:

push:

branches:

- master

Copy link

Collaborator

kstepanovdev Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our main branch is main I suppose

StanChe reviewed Jul 10, 2024

View reviewed changes

snorochevskiy approved these changes Jul 10, 2024

View reviewed changes

rwwwx added 3 commits July 10, 2024 15:20

fixed comments added README.md

232fbd3

remove Cargo.lock from PR

7257b0e

formating fix

730d034

rwwwx marked this pull request as ready for review July 10, 2024 12:50

rwwwx requested review from kstepanovdev and StanChe July 10, 2024 12:51

kstepanovdev approved these changes Jul 10, 2024

View reviewed changes

rwwwx merged commit 3369062 into refactor-and-bugfixing Jul 10, 2024
3 checks passed

rwwwx deleted the MGT-237-CI-CD branch July 10, 2024 12:56

kstepanovdev pushed a commit that referenced this pull request Jul 11, 2024

[MTG-237] ci cd (#17)

9ab7c8e

fixed CI/CD, added README.md and cargo audit

kstepanovdev pushed a commit that referenced this pull request Jul 12, 2024

[MTG-237] ci cd (#17)

4fef498

fixed CI/CD, added README.md and cargo audit

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MTG-237] ci cd #17

[MTG-237] ci cd #17

rwwwx commented Jul 9, 2024

kstepanovdev Jul 10, 2024

kstepanovdev Jul 10, 2024 •

edited

Loading

snorochevskiy Jul 10, 2024

kstepanovdev Jul 10, 2024

StanChe left a comment

StanChe Jul 10, 2024

rwwwx Jul 10, 2024

snorochevskiy Jul 10, 2024

kstepanovdev left a comment

		@@ -0,0 +1,8 @@
		[advisories]
		ignore = ["RUSTSEC-2024-0344", "RUSTSEC-2022-0093"] # ignore unfixable vulnerabilities

[MTG-237] ci cd #17

[MTG-237] ci cd #17

Conversation

rwwwx commented Jul 9, 2024

kstepanovdev Jul 10, 2024

Choose a reason for hiding this comment

kstepanovdev Jul 10, 2024 • edited Loading

Choose a reason for hiding this comment

snorochevskiy Jul 10, 2024

Choose a reason for hiding this comment

kstepanovdev Jul 10, 2024

Choose a reason for hiding this comment

StanChe left a comment

Choose a reason for hiding this comment

StanChe Jul 10, 2024

Choose a reason for hiding this comment

rwwwx Jul 10, 2024

Choose a reason for hiding this comment

snorochevskiy Jul 10, 2024

Choose a reason for hiding this comment

kstepanovdev left a comment

Choose a reason for hiding this comment

kstepanovdev Jul 10, 2024 •

edited

Loading