Threw an error if weighted_stake_diffs.entry() is empty
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTG-400 Throw errors on weighted_stake_diffs.entry()
s.cherviakov said in MTG-80:
|
programs/rewards/src/error.rs
Outdated
|
|
||
| /// 13 | ||
| /// No need to transfer zero amount of rewards. | ||
| #[error("'weighted_stake_diffs' entry cannot be empty")] |
There was a problem hiding this comment.
Suggested change
| #[error("'weighted_stake_diffs' entry cannot be empty")] | |
| #[error("No changes at the date in weighted stake modifiers while they're expected")] |
programs/rewards/src/error.rs
Outdated
| /// 13 | ||
| /// No need to transfer zero amount of rewards. | ||
| #[error("'weighted_stake_diffs' entry cannot be empty")] | ||
| WeightedStakeDiffEntryIsEmpty, |
There was a problem hiding this comment.
May this error be slightly more meaningful? What about NoWeightedStakeModifiersAtADate or something like that?
kstepanovdev
approved these changes
Jul 17, 2024
kstepanovdev
added a commit
that referenced
this pull request
Jul 22, 2024
* rename RestakeDeposit to ExtendStake * add days lockup days to Flex * imporove uninitialize assertion * rename RewardPool:fill to RewardPool:distribute * from now fill cannot be invoked if rewards equals to zero * refactor DistributeRewards::process * refactor withdraw_mining * add fn for mining account closing * deposit_authority don't have to be mutable in close_mining ix * use more clear variable for RewardCalculator::update_index * regenerate IDL and clients * Initialize rewards-pool deposit authority signature (#15) * Initialize rewards-pool deposit authority signature * fixed comments and fmt * Throw an error instead of returning Ok() when 'rewards == 0' * removed elvis operator * [MTG-237] ci cd (#17) fixed CI/CD, added README.md and cargo audit * Fix comment in instruction.rs * Forbid closing mininig if there are pending rewards * Add comment regarding closing accounts * Unify Contexts && verification checks (#21) Unify Contexts and verification checks * mtg-425: Error handling improvements (#22) improved error handling * Threw an error if `weighted_stake_diffs.entry()` is empty (#25) Threw an error if `weighted_stake_diffs.entry()` is empty * [Mtg-296] delegated staking extend staking with delegate parameter (#18) * initial design * fix tests for delegated initial design * Extend extend_stake instruction with delegate parameter Extend deposit_mining instruction with delegate parameter * Refactor and make arithmetic operations more readable * Add tests for delegated staking * minor fix * [MTG-237] ci cd (#17) fixed CI/CD, added README.md and cargo audit * Change ordering for PartialOrd and Ord for LockupPeriod * refactor * refactor asserts * remove redundant substraction from delegated stake check * Forbid mining account from closing if it has stake_from_others * remove useless comment * add delegate_mining field to the withdraw_mining && remove verification for weighted stake since it's done on the staking contract * initial design * fix tests for delegated initial design * Extend extend_stake instruction with delegate parameter Extend deposit_mining instruction with delegate parameter * Refactor and make arithmetic operations more readable * Add tests for delegated staking * Change ordering for PartialOrd and Ord for LockupPeriod * refactor * refactor asserts * remove redundant substraction from delegated stake check * Forbid mining account from closing if it has stake_from_others * remove useless comment * add delegate_mining field to the withdraw_mining && remove verification for weighted stake since it's done on the staking contract * remove useless imports * add more packing on closing account * update tests * remove redundant packing * [mtg-308] (#24) * add change delegate function * change_delegate: add an early return for the case when new_delegate_mining and old_delegate_mining are the same * satisfy clippy * [mtg-297] add stake_from_others for rewards calculations (#26) * add change delegate function * change_delegate: add an early return for the case when new_delegate_mining and old_delegate_mining are the same * satisfy clippy * add stake_from_others for rewards calculations * satisfy clippy * update tests && rebase * Add refreshing of rewards for delegate mining each time it's stake_from_others changes * Update programs/rewards/src/instruction.rs Co-authored-by: Stanislav Cherviakov <[email protected]> * minor fix after merge commit --------- Co-authored-by: Stanislav Cherviakov <[email protected]> --------- Co-authored-by: Matiukhin Vlad <[email protected]> Co-authored-by: Stanislav Cherviakov <[email protected]> --------- Co-authored-by: Kyrylo Stepanov <[email protected]> Co-authored-by: Matiukhin Vlad <[email protected]> Co-authored-by: rwwwx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.