Skip to content

Commit

Permalink
Merge georust#451
Browse files Browse the repository at this point in the history
451: Don't derive Clone, PartialEq and Eq for ExtendedDataType r=metasim a=lnicola

- [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md).
- [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---

Fixes georust#449

Co-authored-by: Laurențiu Nicola <[email protected]>
  • Loading branch information
bors[bot] and lnicola authored Oct 4, 2023
2 parents f638618 + b585c6e commit 57db2d3
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 8 deletions.
19 changes: 12 additions & 7 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,19 @@

## Unreleased

- Refactored `dataset.rs` to focus on core `Dataset` operations, moving ancillary types and operations to other files.
- **Breaking**: Moved `LayerIterator`, `LayerOptions` and `Transaction` to `crate::vector`.
- Accessors `MajorObject::gdal_object_ptr` and `Dataset::c_dataset()` are no longer marked as `unsafe` (it's not idiomatic Rust to do so).
- <https://github.com/georust/gdal/pull/447>
- Fixed build script error with development GDAL versions
- **Breaking**: `ExtendedDataType` no longer implements `Clone`, `PartialEq` and `Eq`

- <https://github.com/georust/gdal/pull/451>

- **Breaking**: Moved `LayerIterator`, `LayerOptions` and `Transaction` to `crate::vector`

- <https://github.com/georust/gdal/pull/447>

- Accessors `MajorObject::gdal_object_ptr` and `Dataset::c_dataset()` are no longer marked as `unsafe` (only using these is unsafe in idiomatic Rust)

- <https://github.com/georust/gdal/pull/447>

- Fixed build script error with development GDAL versions

- <https://github.com/georust/gdal/pull/439>

Expand Down
2 changes: 1 addition & 1 deletion src/raster/mdarray.rs
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ impl<'a> Dimension<'a> {
}

/// Wrapper for `GDALExtendedDataType`
#[derive(Clone, Debug, PartialEq, Eq)]
#[derive(Debug)]
pub struct ExtendedDataType {
c_data_type: GDALExtendedDataTypeH,
}
Expand Down

0 comments on commit 57db2d3

Please sign in to comment.