Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

how about add an option to specify non-utf8 encoding of zip filename #147

Closed
zxdvd opened this issue Mar 1, 2019 · 4 comments
Closed

how about add an option to specify non-utf8 encoding of zip filename #147

zxdvd opened this issue Mar 1, 2019 · 4 comments

Comments

@zxdvd
Copy link

zxdvd commented Mar 1, 2019

What would you like to have changed?

I'd like to add an option like -encoding or -O just like unzip to specify the filename encoding of zip file.

Why is this feature a useful, necessary, and/or important addition to this project?

I work with mac and linux server but lots of colleagues work with windows. I have much terrible experience with zip files from them. The filenames always got messy. I think lots of people suffer same things.

It's easy to implement and lots of people will benefit.

What alternatives are there, or what are you doing in the meantime to work around the lack of this feature?

The unzip has a option -O but it seems that the default unzip on osx do not have this option.

@hy05190134
Copy link

@zxdvd author is very busy

@mholt
Copy link
Owner

mholt commented Mar 1, 2019

Yep, will get around to things eventually

@zxdvd
Copy link
Author

zxdvd commented Mar 1, 2019

I just submitted a PR for this. Could you help to review it?

yumenaka added a commit to yumenaka/archiver that referenced this issue Dec 5, 2021
mholt added a commit that referenced this issue Jan 2, 2022
@mholt
Copy link
Owner

mholt commented Jan 2, 2022

@zxdvd Thank you very much for the contribution, I learned something new from it. Sorry I didn't get around to it for a couple years. I implemented your change in #302 which is a complete library rewrite, and gave you credit in the code and in the commit. Thanks again for contributing

@mholt mholt closed this as completed Jan 2, 2022
mholt added a commit that referenced this issue Jan 4, 2022
#302)

* Initial commit of v4 rewrite; core types, methods

* Correct file permissions

* Use xz lib with standard license (close #259)

* zip: Decode non-UTF-8 encoded filenames (by @zxdvd)

Closes #147
Supersedes #149

* Improve ArchiveFS; fix directory traversal

* Add placeholder command for now

Not sure when I'll get around to reimplementing this for v4.

* ci: Require Go 1.17

* Swap params for Inserter interface

More aesthetically pleasing when enumerating files

* Add readme
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants