Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

xi2 License Dependency #259

Closed
ukclivecox opened this issue Nov 3, 2020 · 6 comments
Closed

xi2 License Dependency #259

ukclivecox opened this issue Nov 3, 2020 · 6 comments

Comments

@ukclivecox
Copy link

This project as xi2/xz as a dependency

github.com/xi2/xz v0.0.0-20171230120015-48954b6210f8

However, that project has not used a standard license:

https://github.com/xi2/xz/blob/master/LICENSE

This is causing us problems with 3rd party open source dependency license validation. Is there any possibility of forking that library to republish it with a standard license? I have added an issue to their project xi2/xz#10 but it seems inactive.

@mholt
Copy link
Owner

mholt commented Nov 3, 2020

I hadn't noticed... are you really not able to use software in the public domain?

@ukclivecox
Copy link
Author

We are and our software is open source but unless a software project we use has a legally well known and clarified license it makes things less clear and harder to verify its status.

@coolaj86
Copy link
Collaborator

coolaj86 commented Nov 3, 2020

@mholt I think the problem is that "Public Domain" is not a license that can be detected with automated tooling.
The MIT license et al can be automatically detected with tooling because they use exact phrases and wording.

@ukclivecox
Copy link
Author

Another issue is marketplaces such as Google accept a limited set of well established licences. By taking the approach of creating a custom license with "reasonable sounding" words makes it harder for these software projects to be accepted when scrutinized in strict environments. Its a shame as I am sure the xi2 project would probably be happy with MIT or Apache 2.0 wording.

@coolaj86
Copy link
Collaborator

Having not heard anything back from the project's author, I created a fork with the LICENSE:

https://github.com/therootcompany/xz

Perhaps you could use the replace directive in go.mod?

@mholt
Copy link
Owner

mholt commented Jan 2, 2022

Fixed in #302.

Tried using a replace directive but got this error:

go: finding module for package github.com/therootcompany/xz
go: found github.com/therootcompany/xz in github.com/therootcompany/xz v1.0.1
go: github.com/therootcompany/[email protected] used for two different module paths (github.com/therootcompany/xz and github.com/xi2/xz)

so I had to just swap it out entirely, nbd. Thanks!

@mholt mholt closed this as completed Jan 2, 2022
mholt added a commit that referenced this issue Jan 4, 2022
#302)

* Initial commit of v4 rewrite; core types, methods

* Correct file permissions

* Use xz lib with standard license (close #259)

* zip: Decode non-UTF-8 encoded filenames (by @zxdvd)

Closes #147
Supersedes #149

* Improve ArchiveFS; fix directory traversal

* Add placeholder command for now

Not sure when I'll get around to reimplementing this for v4.

* ci: Require Go 1.17

* Swap params for Inserter interface

More aesthetically pleasing when enumerating files

* Add readme
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants