Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated canvas-prebuilt by canvas #96

Closed

Conversation

matthieu-foucault
Copy link

Fixes #94
I also added the cross-env dev dependency, allowing to run build scripts on windows

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files          11       11           
  Lines         231      231           
=======================================
  Hits          221      221           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0856c28...0856c28. Read the comment docs.

@michalochman
Copy link
Owner

michalochman commented Feb 11, 2019

Hey @matthieu-foucault, that's not what I wanted to do at all and now I can't revert it. Would you please do it again, but this time also remove canvas-prebuilt from package.json? I have pushed master instead of updated branch to your PR.

Here's the lost commit:
https://github.com/matthieu-foucault/react-pixi-fiber/compare/db0374f48c06136a5045616c0e4267a3d36b5651..0856c28f75ed2e6a5ff4af288e774a11488142c7

@michalochman
Copy link
Owner

@matthieu-foucault nevermind, I found the commit in my refs with you as the author #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants