-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated canvas-prebuilt by canvas #97
Conversation
@matthieu-foucault looks like tests do not pass when you remove
|
Looks like this is because the current |
The tests for this PR did pass on CircleCI though 🤔 |
That's because I have solution to it thought through custom jest environment thought so I'll update this PR shortly. |
🤦♂️ |
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 11 11
Lines 231 231
=======================================
Hits 221 221
Misses 10 10 Continue to review full report at Codecov.
|
Fixes #94
@matthieu-foucault also added the
cross-env
dev dependency, allowing to run build scripts on windows