Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated canvas-prebuilt by canvas #97

Merged
merged 3 commits into from
Feb 23, 2019
Merged

Replace deprecated canvas-prebuilt by canvas #97

merged 3 commits into from
Feb 23, 2019

Conversation

michalochman
Copy link
Owner

Fixes #94

@matthieu-foucault also added the cross-env dev dependency, allowing to run build scripts on windows

@michalochman
Copy link
Owner Author

@matthieu-foucault looks like tests do not pass when you remove canvas-prebuilt from dependencies.

TypeError: Cannot set property 'fillStyle' of null

@michalochman
Copy link
Owner Author

michalochman commented Feb 11, 2019

Looks like this is because the current jest version is using jsdom that can not work with canvas@2 yet.

https://github.com/facebook/jest/blob/d792940b01ee1e17e435574e6cf4830b5186245e/packages/jest-environment-jsdom/package.json#L14

@matthieu-foucault
Copy link

The tests for this PR did pass on CircleCI though 🤔

@michalochman
Copy link
Owner Author

That's because canvas-prebuilt is still in devDependencies ;)

I have solution to it thought through custom jest environment thought so I'll update this PR shortly.

@matthieu-foucault
Copy link

That's because canvas-prebuilt is still in devDependencies ;)

🤦‍♂️

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files          11       11           
  Lines         231      231           
=======================================
  Hits          221      221           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fee831...0d42566. Read the comment docs.

@michalochman michalochman merged commit 6bae161 into master Feb 23, 2019
@michalochman michalochman deleted the pr96 branch February 23, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants