-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add banner for re-iding #1214
Add banner for re-iding #1214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. This branch should be tagged as a patch release, and this PR will likely get closed without being merged into main (this change is temporary).
I opened a PR (with this branch as the base/target/destination) in which I made the changes I proposed above. |
…-typo Fix spelling error and hyperlink formatting
The current commit is tagged as https://github.com/microbiomedata/nmdc-server/releases/tag/v0.19.3. |
Apologies, the app prop appears to be adding the sticky value even though that is not indicated in the docs. I will remove the prop |
fixed in 4a6861e @eecavanna do you mind taking another look before I create another tag? |
Looks good to me, @marySalvi! Thanks for taking care of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #1211
Fixes #1217