Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner for re-iding #1214

Merged
merged 8 commits into from
Apr 23, 2024
Merged

Add banner for re-iding #1214

merged 8 commits into from
Apr 23, 2024

Conversation

marySalvi
Copy link
Collaborator

@marySalvi marySalvi commented Apr 18, 2024

Closes #1211
Fixes #1217

@marySalvi marySalvi requested a review from naglepuff April 18, 2024 16:34
Copy link
Collaborator

@naglepuff naglepuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. This branch should be tagged as a patch release, and this PR will likely get closed without being merged into main (this change is temporary).

@eecavanna
Copy link
Collaborator

eecavanna commented Apr 18, 2024

I opened a PR (with this branch as the base/target/destination) in which I made the changes I proposed above.

#1216

@eecavanna
Copy link
Collaborator

eecavanna commented Apr 18, 2024

The current commit is tagged as https://github.com/microbiomedata/nmdc-server/releases/tag/v0.19.3.

@eecavanna
Copy link
Collaborator

Looks like something's a little whack with the z-indexing. When I scroll down the page, the banner follows the viewport (I don't know whether that was by design) and it appears above some elements (e.g. the bar charts) and below others (e.g. the map).

image

@eecavanna
Copy link
Collaborator

If I disable the following CSS styles currently being applied to the .v-banner element, the banner no longer sticks to the viewport.

    top: 82px;
    position: sticky;

image

I propose this—conceptually—as a fix. There might be a Vue/Vuetify setting/prop that would make these same CSS changes under the hood.

@marySalvi
Copy link
Collaborator Author

marySalvi commented Apr 19, 2024

I propose this—conceptually—as a fix. There might be a Vue/Vuetify setting/prop that would make these same CSS changes under the hood.

Apologies, the app prop appears to be adding the sticky value even though that is not indicated in the docs. I will remove the prop

@marySalvi marySalvi requested a review from eecavanna April 19, 2024 14:20
@marySalvi
Copy link
Collaborator Author

I propose this—conceptually—as a fix. There might be a Vue/Vuetify setting/prop that would make these same CSS changes under the hood.

fixed in 4a6861e @eecavanna do you mind taking another look before I create another tag?

@eecavanna
Copy link
Collaborator

Looks good to me, @marySalvi! Thanks for taking care of this.

@marySalvi marySalvi requested a review from naglepuff April 23, 2024 15:48
@marySalvi
Copy link
Collaborator Author

#1217 fixed with 813f50d

Copy link
Collaborator

@naglepuff naglepuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marySalvi marySalvi merged commit 7429695 into main Apr 23, 2024
2 checks passed
@marySalvi marySalvi deleted the app-banner branch April 23, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar scrolls down with viewport, overlapping other elements post re-iding notification banner
3 participants