Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling error and hyperlink formatting #1216

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Fix spelling error and hyperlink formatting #1216

merged 3 commits into from
Apr 18, 2024

Conversation

eecavanna
Copy link
Collaborator

@eecavanna eecavanna commented Apr 18, 2024 •
edited
Loading

This PR branch includes three changes:

  • A spelling error is fixed: 
    - Anouncement
+ Announcement
  • Hyperlinks are no longer followed by an underlined space
  • Makes the line height consistent throughout the banner (previously, first line differed)

Before:

image

After:

image

@eecavanna eecavanna self-assigned this Apr 18, 2024
@eecavanna eecavanna marked this pull request as ready for review April 18, 2024 23:16
@eecavanna eecavanna mentioned this pull request Apr 18, 2024
Merged
@eecavanna eecavanna requested a review from pkalita-lbl April 18, 2024 23:51
@eecavanna eecavanna merged commit c673079 into app-banner Apr 18, 2024
2 checks passed
@eecavanna eecavanna deleted the eecavanna/app-banner-fix-typo branch April 18, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkalita-lbl pkalita-lbl pkalita-lbl approved these changes

@marySalvi marySalvi Awaiting requested review from marySalvi

@naglepuff naglepuff Awaiting requested review from naglepuff

Assignees

@eecavanna eecavanna

Labels
None yet
Projects
No open projects
2024 - Sprint 34 - April 8 - April 19, 2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eecavanna @pkalita-lbl