Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ROS client package in python #1477

Closed
wants to merge 4 commits into from

Conversation

Mayankm96
Copy link

I have added a standalone package for ROS which interfaces with the AirSim plugin using the Python APIs. It is a followup on the issue #1326. Currently the following implementations are supported:

  • client node to retrieve the drone's pose and camera images (rgb, depth)
  • client node that subscribes to an array of waypoints message and follows a trajectory
  • urdf file for the drone to publish static transformations

The package can also be found out here. I hope to add more implementations depending on the suggestions and ideas I receive, but this is all that I have done so far.

@msftclas
Copy link

msftclas commented Oct 18, 2018

CLA assistant check
All CLA requirements met.

@sytelus
Copy link
Contributor

sytelus commented Oct 25, 2018

Hi @Mayankm96 - thanks for your contribution! We see few issues and wondering if we can clean this up.

  1. Can we remove your private copy of PythonClient? If you are looking to set path to existing PythonClient then look for setup_path.py which does this.

  2. There are bunch of DJI meshes and binary files. Are these under MIT license? If you had downloaded from commercial websites, could you please let us know what is redistribution policy?

@Mayankm96
Copy link
Author

Mayankm96 commented Oct 26, 2018

Hey @sytelus,

  1. I have deleted the PythonClient folder.

  2. The DJI M100 mesh was downloaded from GrabCAD (link). Under the terms of GrabCAD (link), I suppose the model can be used only for non-commercial use with proper credits to the original contributor.

@Mayankm96
Copy link
Author

Sorry I checked the GrabCAD page again. The STEP file used there was downloaded from DJI website. The link to the same is https://www.dji.com/matrice100/info#downloads.

@sytelus
Copy link
Contributor

sytelus commented Nov 1, 2018

Thanks Mayank! Just one more thing... we already have few ROS publisher nodes contributed by someone else here:
https://github.com/Microsoft/AirSim/tree/master/PythonClient/ros

Do you think we can merge this existing ROS code with your PR so we have only one official story for ROS.

@TritonSailor
Copy link
Contributor

Hi, great to see more ROS support. Please don't make any breaking changes to the existing ROS code. I have a project underway with PR in, to add Nvidia neural network navigation support for AirSim that relies on this code.

https://www.youtube.com/watch?v=9a-wvXwpRZk

NVIDIA-AI-IOT/redtail#93

Documentation in progress here: https://github.com/TritonSailor/redtail/wiki/Getting-Started-with-Autonomous-Navigation-Training-and-Testing-using-airsim_ros-package

@Mayankm96
Copy link
Author

Mayankm96 commented Nov 1, 2018

@sytelus Yeah sure, I can do that. I also think the code I have written can be improved a lot. It would be better to have the functionalities in form of python classes which can be imported into a python node and be used directly. I was looking into carla_ros_bridge for inspiration.

@TritonSailor I suppose my PR would take a while to get accepted. There is still a lot that I feel needs to be done to have the kind of ROS support a user would like for AirSim. Don't worry :)

@sytelus
Copy link
Contributor

sytelus commented Nov 8, 2018

Hi @Mayankm96 - thanks for taking this initiative! Looking forward to your next update!!

@madratman madratman self-assigned this Dec 14, 2018
@madratman
Copy link
Contributor

closing as a generic version was added in #1911

@madratman madratman closed this May 13, 2019
@madratman
Copy link
Contributor

@Mayankm96 this was a pretty good contribution, but unfortunately I didn't merge this as it would have required the user to keep writing callbacks manually with different vehicles/sensors/cameras.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants