-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ROS client package in python #1477
Conversation
Hi @Mayankm96 - thanks for your contribution! We see few issues and wondering if we can clean this up.
|
Sorry I checked the GrabCAD page again. The STEP file used there was downloaded from DJI website. The link to the same is https://www.dji.com/matrice100/info#downloads. |
Thanks Mayank! Just one more thing... we already have few ROS publisher nodes contributed by someone else here: Do you think we can merge this existing ROS code with your PR so we have only one official story for ROS. |
Hi, great to see more ROS support. Please don't make any breaking changes to the existing ROS code. I have a project underway with PR in, to add Nvidia neural network navigation support for AirSim that relies on this code. https://www.youtube.com/watch?v=9a-wvXwpRZk Documentation in progress here: https://github.com/TritonSailor/redtail/wiki/Getting-Started-with-Autonomous-Navigation-Training-and-Testing-using-airsim_ros-package |
@sytelus Yeah sure, I can do that. I also think the code I have written can be improved a lot. It would be better to have the functionalities in form of python classes which can be imported into a python node and be used directly. I was looking into carla_ros_bridge for inspiration. @TritonSailor I suppose my PR would take a while to get accepted. There is still a lot that I feel needs to be done to have the kind of ROS support a user would like for AirSim. Don't worry :) |
Hi @Mayankm96 - thanks for taking this initiative! Looking forward to your next update!! |
closing as a generic version was added in #1911 |
@Mayankm96 this was a pretty good contribution, but unfortunately I didn't merge this as it would have required the user to keep writing callbacks manually with different vehicles/sensors/cameras. |
I have added a standalone package for ROS which interfaces with the AirSim plugin using the Python APIs. It is a followup on the issue #1326. Currently the following implementations are supported:
The package can also be found out here. I hope to add more implementations depending on the suggestions and ideas I receive, but this is all that I have done so far.