Rework travis.yml #2356
Rework travis.yml #2356
Conversation
|
Windows build is working now, build with this commit on my Travis page: https://travis-ci.com/rajat2004/AirSim/builds/142728157 |
rajat2004
force-pushed
the
travis-rework
branch
2 times, most recently
from
07e2c27 to
79204af
Compare
rajat2004
force-pushed
the
travis-rework
branch
2 times, most recently
from
c93ed9d to
3f24387
Compare
rajat2004
force-pushed
the
travis-rework
branch
from
3f24387 to
1a223e2
Compare
rajat2004
force-pushed
the
travis-rework
branch
from
1a223e2 to
17de60d
Compare
rajat2004
force-pushed
the
travis-rework
branch
4 times, most recently
from
62948d4 to
1a976b7
Compare
rajat2004
force-pushed
the
travis-rework
branch
2 times, most recently
from
2c4cd7f to
9986123
Compare
|
lgtm on the first part, quite some unnecessary if else's in the original file. |
|
https://travis-ci.com/github/rajat2004/AirSim/builds/154715324 |
rajat2004
force-pushed
the
travis-rework
branch
from
9986123 to
c032116
Compare
|
yeah, I somehow missed the links on the top of the page - hence deleted my comment. thanks though |
Remove docker build, add Ubuntu 18.04, 16.04, Windows, OSX builds Hack for correct Find.exe on Windows, issue microsoft#1753 Hack for reducing compilation warning output while still seeing errors
Fix copying of directory
|
Don't know why Travis build isn't appearing on this PR, current build of master with the branch - https://travis-ci.com/github/rajat2004/AirSim/builds/155782696 |
| else | ||
| export CC="clang-5.0" | ||
| export CXX="clang++-5.0" | ||
| fi |
There was a problem hiding this comment.
do we know which version of clang these pre-built binaries are?
does travis allow for choosing a version of pre-built binaries?
In general, I am planning to remove the custom libcxx in airsim's setup.sh scripts.
https://docs.unrealengine.com/en-US/Platforms/Linux/GettingStarted/index.html if one uses the clang version with the right unreal version as specified in that page, a custom libcxx build can be obviated.
hence, curious to know which version are these pre built binaries and is there an option to select them
There was a problem hiding this comment.
I've specified the binary version here - https://github.com/microsoft/AirSim/pull/2356/files#diff-354f30a63fb0907d4ad57269548329e3R27
Removing the need for custom libcxx would be good
There was a problem hiding this comment.
ah cool, that's exactly the kind of line I was trying to find.
PR is looking good to me.
I am not sure if travis has a weird edge case when one updates the yml itself? However, I would be surprised if that isn't handled by them
There was a problem hiding this comment.
It works even when travis.yml is updated, might be a problem with AirSim itself, have noticed that the build doesn't appear on the other PRs also
There was a problem hiding this comment.
really weird. accio @sytelus, if I may.
There was a problem hiding this comment.
@madratman @sytelus Were you able to figure out why the Travis build isn't working? It's still not triggering on the PRs
|
Wow, great, thanks for merging! |
Remove docker build, add Ubuntu 18.04, 16.04, and Windows, macOS builds using
build.shas well asUnity/build.shThis should help in catching breaking changes on different OSes, as well as on Unreal vs Unity
Unfortunately adding Unreal inside Travis doesn't seem possible
Should GCC build be added also?
Unity compilation throws about 340 warnings, which exceeds the Travis output log size (4 MB), seems like incorrect flags are being applied to the Unity build (Created issue #2478 for discussion)
Needs #2333 and #2328 (if only #2333 is there, CMake won't be downloaded when it's not required and without the fix of build.sh in #2328, cmake won't be found)