Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework travis.yml #2356

Merged
merged 4 commits into from
Mar 27, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 35 additions & 52 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,73 +1,56 @@
language: cpp
#git:
# shorten this if we can nail down submodule depth
# depth: 3

fast_finish: false

matrix:
jobs:
allow_failures:
- env: ALLOW_FAILURES=true

include:
# linux version have unique dependencies, so we set them up individually
- os: linux
dist: trusty
sudo: required
services:
- docker
#- os: windows
# dotnet: 2.1.5
# services:
# - docker

- name: Ubuntu 18.04
os: linux
dist: bionic

# OS X CMake
#- os: osx
# sudo: required
# osx_image: xcode8.2
# compiler:
# - clang
# env:
# - TOOL="cmake"
# - DESCRIPTION="OS X build/test via CMake"
- name: Ubuntu 16.04
os: linux
dist: xenial

- name: Windows 10
os: windows
env:
- MSBUILD_PATH="c:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin"
- PATH_FIX="C:\Windows\System32"

- name: MacOS
os: osx
env:
- TOOL="cmake"
- DESCRIPTION="OS X build/test via CMake"
- LLVM_PACKAGE="clang+llvm-5.0.2-x86_64-apple-darwin"
- CIINSTALL=yes

# docker exec xenial apt-get -y install clang libclang-3.8-dev;
install:
- if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then
docker pull ubuntu:xenial;
docker run -d --name xenial -dti ubuntu:xenial bash;
docker ps -a;
docker exec xenial mkdir /build;
docker cp . xenial:/build;
docker exec xenial apt-get update;
docker exec xenial apt-get -y upgrade;
docker exec xenial apt-get -y install git wget unzip sudo;
docker exec xenial apt-get -y install build-essential software-properties-common cmake;
docker exec xenial apt-get update;
elif [[ "$TRAVIS_OS_NAME" == "windows" ]]; then
echo "No install osx actions--using repo";
elif [[ "$TRAVIS_OS_NAME" == "osx" ]] && [[ "$TOOL" == "cmake" ]]; then
echo "No install Windows actions--using repo";
fi

before_install:
- if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then
echo "No pre-install linux actions--using docker";
sudo apt-get update;
sudo apt-get -y install git wget unzip;
sudo apt-get -y install build-essential software-properties-common cmake rsync libboost-all-dev;
elif [[ "$TRAVIS_OS_NAME" == "osx" ]] && [[ "$TOOL" == "cmake" ]]; then
echo "No pre-install osx actions";
wget http://releases.llvm.org/5.0.2/${LLVM_PACKAGE}.tar.xz;
tar -xf ${LLVM_PACKAGE}.tar.xz;
export LLVM_DIR=${TRAVIS_BUILD_DIR}/${LLVM_PACKAGE};
fi

#docker exec xenial /bin/sh -c "export EIGEN3_INCLUDE_DIR=/build/eigen/eigen3 && cd /build/cmake && sh ./build.sh && cmake . && make";
script:
- if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then
docker exec -t xenial /build/setup.sh;
docker exec -t xenial /build/build.sh;
./setup.sh;
./build.sh;
cd Unity && ./build.sh 2> Unity_error.txt || (tail -n 100 Unity_error.txt && exit 1);
elif [[ "$TRAVIS_OS_NAME" == "windows" ]]; then
.\\build.cmd;
.\\Unity\\build.cmd;
export PATH=$MSBUILD_PATH:$PATH_FIX:$PATH;
cmd.exe //C 'C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Auxiliary\Build\vcvarsall.bat' amd64 '&&'
build.cmd '&&'
cd Unity '&&' build.cmd;
elif [[ "$TRAVIS_OS_NAME" == "osx" ]]; then
git submodule update --init --recursive;
./setup.sh;
./build.sh;
cd Unity && ./build.sh 2> Unity_error.txt || (tail -n 100 Unity_error.txt && exit 1);
fi
11 changes: 8 additions & 3 deletions Unity/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,13 @@ fi


cd linux-build;
export CC="clang-5.0"
export CXX="clang++-5.0"
if [[ -n $CIINSTALL ]]; then # use downloaded binaries on Travis
export CC=${LLVM_DIR}/bin/clang
export CXX=${LLVM_DIR}/bin/clang++
else
export CC="clang-5.0"
export CXX="clang++-5.0"
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know which version of clang these pre-built binaries are?
does travis allow for choosing a version of pre-built binaries?

In general, I am planning to remove the custom libcxx in airsim's setup.sh scripts.
https://docs.unrealengine.com/en-US/Platforms/Linux/GettingStarted/index.html if one uses the clang version with the right unreal version as specified in that page, a custom libcxx build can be obviated.

hence, curious to know which version are these pre built binaries and is there an option to select them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've specified the binary version here - https://github.com/microsoft/AirSim/pull/2356/files#diff-354f30a63fb0907d4ad57269548329e3R27

Removing the need for custom libcxx would be good

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah cool, that's exactly the kind of line I was trying to find.
PR is looking good to me.
I am not sure if travis has a weird edge case when one updates the yml itself? However, I would be surprised if that isn't handled by them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works even when travis.yml is updated, might be a problem with AirSim itself, have noticed that the build doesn't appear on the other PRs also

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really weird. accio @sytelus, if I may.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madratman @sytelus Were you able to figure out why the Travis build isn't working? It's still not triggering on the PRs


if [ "$(uname)" == "Darwin" ]; then
CMAKE="$(greadlink -f ../../cmake_build/bin/cmake)"
Expand All @@ -25,7 +30,7 @@ if [ ! -d "../UnityDemo/Assets/Plugins" ]; then
fi

if [ "$(uname)" == "Darwin" ]; then
cp AirsimWrapper.bundle ../UnityDemo/Assets/Plugins;
cp -r AirsimWrapper.bundle ../UnityDemo/Assets/Plugins;
else
cp libAirsimWrapper.so ../UnityDemo/Assets/Plugins;
fi
Expand Down
11 changes: 9 additions & 2 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,15 @@ else
# variable for build output
build_dir=build_debug
if [ "$(uname)" == "Darwin" ]; then
export CC=/usr/local/opt/llvm-5.0/bin/clang-5.0
export CXX=/usr/local/opt/llvm-5.0/bin/clang++-5.0

if [[ -n $CIINSTALL ]]; then # use downloaded binaries on Travis
export CC=${LLVM_DIR}/bin/clang
export CXX=${LLVM_DIR}/bin/clang++
else
export CC=/usr/local/opt/llvm-5.0/bin/clang-5.0
export CXX=/usr/local/opt/llvm-5.0/bin/clang++-5.0
fi

else
export CC="clang-5.0"
export CXX="clang++-5.0"
Expand Down
18 changes: 12 additions & 6 deletions setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,19 @@ if $gccBuild; then
else
# llvm tools
if [ "$(uname)" == "Darwin" ]; then # osx
brew update

# brew install [email protected]
brew tap llvm-hs/homebrew-llvm
brew install llvm-5.0
export C_COMPILER=/usr/local/opt/llvm-5.0/bin/clang-5.0
export COMPILER=/usr/local/opt/llvm-5.0/bin/clang++-5.0
if [[ -n $CIINSTALL ]]; then # use downloaded binaries on Travis
export C_COMPILER=${LLVM_DIR}/bin/clang
export COMPILER=${LLVM_DIR}/bin/clang++
else
brew update

# brew install [email protected]
brew tap llvm-hs/homebrew-llvm
brew install llvm-5.0
export C_COMPILER=/usr/local/opt/llvm-5.0/bin/clang-5.0
export COMPILER=/usr/local/opt/llvm-5.0/bin/clang++-5.0
fi

else #linux
#install clang and build tools
Expand Down