Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exact Terraform provider versions in bundles #2579

Merged
merged 4 commits into from
Sep 11, 2022

Conversation

tamirkamara
Copy link
Collaborator

Resolves #2578

What is being addressed

Sometimes we use an approximate version of a provider (like ~>1.2.3) in bundles but that can break it when the next minor version is released. So when 1.2.4 will be released the bundle couldn't be installed.
The reason for this issue is that terraform providers mirror doesn't respect the lockfile - it will download the most recent version that respects the required_provider constraint (1.2.4 in the example), however the runtime will try to use the one from the lockfile (1.2.3)

This is a known issue in Terraform

How is this addressed

  • Specify exact provider version in all root modules for bundles
  • Remove the checkpoint setting as that wasn't the issue

@github-actions
Copy link

github-actions bot commented Sep 11, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit cd67fc0.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara marked this pull request as ready for review September 11, 2022 05:33
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3030690572 (with refid 1862abf5)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3030944692 (with refid 1862abf5)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) September 11, 2022 07:59
@tamirkamara tamirkamara merged commit b796dbc into main Sep 11, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2578-exact-tf-providers-version branch September 11, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New versions of Terraform providers break bundles
2 participants