Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a base workspace template with peering #61

Merged
merged 2 commits into from
May 12, 2021
Merged

Add a base workspace template with peering #61

merged 2 commits into from
May 12, 2021

Conversation

deniscep
Copy link
Contributor

@deniscep deniscep commented May 10, 2021 •
edited
Loading

Add a base workspace template with peering

What is being addressed

Adds a base workspace template that can be used for creation of other workspace templates. Doesn't contain any services, only VNET with one subnet and the VNET is peered.

How is this addressed

  • Add a basic terraform structure for workspace creation
  • Add a workspace resource group with VNET, subnet and peering to Core VNET.

Closes 5484 in AzDO

@github-actions
Copy link

github-actions bot commented May 10, 2021 •
edited
Loading

Unit Test Results

1 files  1 suites   0s ⏱️
1 tests 1 ✔️ 0 💤 0 ❌

Results for commit 73696d2.

♻️ This comment has been updated with latest results.

marrobi
marrobi reviewed May 10, 2021
View reviewed changes
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deniscep Couple of comments - not all for yourself... Based on the infra proposal there are a number of items missing fromt he base workspace template. Have we got issues tracking these?

  • NSGs
  • App GW
  • Storage
  • Route Table

Thanks.

templates/workspaces/base_workspace/terraform/locals.tf Outdated Show resolved Hide resolved
templates/workspaces/base_workspace/terraform/network/locals.tf Show resolved Hide resolved
templates/workspaces/base_workspace/terraform/network/network.tf Show resolved Hide resolved
@christoferlof christoferlof linked an issue May 10, 2021 that may be closed by this pull request
Create baseline resource templates #14
Closed
6 tasks
@christoferlof
Copy link
Contributor

christoferlof commented May 10, 2021 •
edited
Loading

#51, #52, #53 are related

@deniscep deniscep merged commit f2b5408 into develop May 12, 2021
@christoferlof christoferlof deleted the feature/5484-workspace-template branch May 12, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrobi marrobi marrobi left review comments

@christoferlof christoferlof christoferlof approved these changes

@TessFerrandez TessFerrandez TessFerrandez approved these changes

@sachinkundu sachinkundu Awaiting requested review from sachinkundu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create baseline resource templates
4 participants
@deniscep @christoferlof @TessFerrandez @marrobi