Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a base workspace template with peering #61

Merged
merged 2 commits into from
May 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions templates/core/terraform/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ resource "azurerm_resource_group" "core" {
location = var.location
name = "rg-${var.resource_name_prefix}-${var.environment}-${local.tre_id}"
tags = {
environment = "Azure Trusted Research Environment"
Source = "https://github.com/microsoft/AzureTRE/"
project = "Azure Trusted Research Environment"
environment = var.environment
core_id = "${var.resource_name_prefix}-${var.environment}-${local.tre_id}"
source = "https://github.com/microsoft/AzureTRE/"
}
}

Expand Down
1 change: 1 addition & 0 deletions templates/core/terraform/network/network.tf
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,6 @@ resource "azurerm_subnet" "shared" {
virtual_network_name = azurerm_virtual_network.core.name
resource_group_name = var.resource_group_name
address_prefixes = [local.shared_services_subnet_address_prefix]
# notice that private endpoints do not adhere to NSG rules
enforce_private_link_endpoint_network_policies = true
}
4 changes: 4 additions & 0 deletions templates/core/terraform/outputs.tf
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
output "core_id" {
value = "${var.resource_name_prefix}-${var.environment}-${local.tre_id}"
}

output "core_resource_group_name" {
value = azurerm_resource_group.core.name
}
Expand Down
5 changes: 0 additions & 5 deletions templates/core/terraform/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ variable "location" {
description = "Azure region for deployment of core TRE services"
}

variable "tre_dns_suffix" {
type = string
description = "DNS suffix for the environment. E.g. .dre.myorg.com or .drelocal - must have >= 2 labels such as x.drelocal"
}

variable "address_space" {
type = string
description = "Core services VNET Address Space"
Expand Down
38 changes: 38 additions & 0 deletions templates/workspaces/base_workspace/terraform/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions templates/workspaces/base_workspace/terraform/locals.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
data "azurerm_subscription" "current" {}

data "azurerm_client_config" "current" {}

# Random unique id
resource "random_string" "unique_id" {
length = 4
min_numeric = 4
}

locals {
core_vnet = "vnet-${var.core_id}"
core_resource_group_name = "rg-${var.core_id}"
}
34 changes: 34 additions & 0 deletions templates/workspaces/base_workspace/terraform/main.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# Azure Provider source and version being used
terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "=2.46.0"
}
}
}

provider "azurerm" {
features {}
}

resource "azurerm_resource_group" "ws" {
location = var.location
name = "rg-${var.core_id}-ws-${var.ws_id}"
tags = {
project = "Azure Trusted Research Environment"
core_id = var.core_id
source = "https://github.com/microsoft/AzureTRE/"
}
}

module "network" {
source = "./network"
ws_id = var.ws_id
core_id = var.core_id
location = var.location
resource_group_name = azurerm_resource_group.ws.name
address_space = var.address_space
core_vnet = local.core_vnet
core_resource_group_name = local.core_resource_group_name
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
locals {
ws_services_vnet_subnets = cidrsubnets(var.address_space, 4)
christoferlof marked this conversation as resolved.
Show resolved Hide resolved
services_subnet_address_prefix = local.ws_services_vnet_subnets[0]
}
35 changes: 35 additions & 0 deletions templates/workspaces/base_workspace/terraform/network/network.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
resource "azurerm_virtual_network" "ws" {
name = "vnet-${var.core_id}-ws-${var.ws_id}"
location = var.location
resource_group_name = var.resource_group_name
address_space = [var.address_space]
}


resource "azurerm_subnet" "services" {
name = "ServicesSubnet"
virtual_network_name = azurerm_virtual_network.ws.name
resource_group_name = var.resource_group_name
address_prefixes = [local.services_subnet_address_prefix]
# notice that private endpoints do not adhere to NSG rules
enforce_private_link_endpoint_network_policies = true
deniscep marked this conversation as resolved.
Show resolved Hide resolved
}

data "azurerm_virtual_network" "core" {
name = var.core_vnet
resource_group_name = var.core_resource_group_name
}

resource "azurerm_virtual_network_peering" "ws-core-peer" {
name = "ws-core-peer-${var.core_id}-ws-${var.ws_id}"
resource_group_name = var.resource_group_name
virtual_network_name = azurerm_virtual_network.ws.name
remote_virtual_network_id = data.azurerm_virtual_network.core.id
}

resource "azurerm_virtual_network_peering" "core-ws-peer" {
name = "core-ws-peer-${var.core_id}-ws-${var.ws_id}"
resource_group_name = var.core_resource_group_name
virtual_network_name = var.core_vnet
remote_virtual_network_id = azurerm_virtual_network.ws.id
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
variable "ws_id" {}
variable "core_id" {}
variable "location" {}
variable "resource_group_name" {}
variable "address_space" {}
variable "core_vnet" {}
variable "core_resource_group_name" {}
3 changes: 3 additions & 0 deletions templates/workspaces/base_workspace/terraform/outputs.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
output "ws_resource_group_name" {
value = azurerm_resource_group.ws.name
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
location = "westeurope"
core_id = "tre-dev-9020"
ws_id = "001"
address_space = "10.2.1.0/24"
19 changes: 19 additions & 0 deletions templates/workspaces/base_workspace/terraform/variables.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
variable "location" {
type = string
description = "Azure region for deployment of core TRE services"
}

variable "core_id" {
type = string
description = "ID of the TRE Core (e.g. tre-dev-1111)"
}

variable "ws_id" {
type = string
description = "Workspace ID (sequential)"
}

variable "address_space" {
type = string
description = "Workspace services VNET Address Space"
}