Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas #6697

Merged
merged 13 commits into from
Apr 8, 2021
Merged

chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas #6697

merged 13 commits into from
Apr 8, 2021

Conversation

carlosscastro
Copy link
Member

#minor

beyackle
beyackle previously approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@a-b-r-o-w-n
Copy link
Contributor

@carlosscastro looks like a test needs to be updated.

@coveralls
Copy link

coveralls commented Apr 6, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-9.0e-05%) to 51.598% when pulling bb53b13 on ccastro/adapter-type-support into 8bea594 on main.

@cwhitten cwhitten merged commit 96d4773 into main Apr 8, 2021
@cwhitten cwhitten deleted the ccastro/adapter-type-support branch April 8, 2021 17:26
alanlong9278 added a commit that referenced this pull request Apr 9, 2021
@alanlong9278
Merge branch 'wenyluo/skill' into julong/skill
313b668 
* wenyluo/skill: (30 commits)
  Force refresh of fluent List via slice (#6810)
  fix: Telemetry for Orchestrator R13 (#6689)
  fix: Fixed broken tenant ID on save (#6809)
  feat: Add devops and app insights to get started (#6790)
  fix: check for node on app start on users machine and notify if not installed (#6578)
  feat: Expose default search query, pre-release flag and type for each feed. (#6781)
  fix: do not provision an endpoint key (#6791)
  remove folder if project fails to create (#6793)
  Removed preview from publish type names (#6795)
  fix: Fixing deep link for QNA and Luis (#6743)
  Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (#6788)
  Added workerRuntime value (#6784)
  fix: apply publishing profile to new runtime during publish (#6719)
  fix: during publish, do not copy project into a build folder (#6729)
  chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (#6697)
  polish UI
  remove trigger when remove skill, fix bugs
  fix orchestractor modal not show
  fix skill not added after add remote skill
  remove allowedCaller when remove skill
  ...
alanlong9278 added a commit that referenced this pull request Apr 9, 2021
@alanlong9278
Merge branch 'main' into qika/skill
318c7d4 
* main:
  fix: make composer support https proxy (#6766)
  Force refresh of fluent List via slice (#6810)
  fix: Telemetry for Orchestrator R13 (#6689)
  fix: Fixed broken tenant ID on save (#6809)
  feat: Add devops and app insights to get started (#6790)
  fix: check for node on app start on users machine and notify if not installed (#6578)
  feat: Expose default search query, pre-release flag and type for each feed. (#6781)
  fix: do not provision an endpoint key (#6791)
  remove folder if project fails to create (#6793)
  Removed preview from publish type names (#6795)
  fix: Fixing deep link for QNA and Luis (#6743)
  Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (#6788)
  Added workerRuntime value (#6784)
  fix: apply publishing profile to new runtime during publish (#6719)
  fix: during publish, do not copy project into a build folder (#6729)
  chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (#6697)
@cwhitten cwhitten mentioned this pull request May 20, 2021
Merged
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
@alanlong9278
Merge branch 'wenyluo/skill' into julong/skill
c0e16c0 
* wenyluo/skill: (30 commits)
  Force refresh of fluent List via slice (microsoft#6810)
  fix: Telemetry for Orchestrator R13 (microsoft#6689)
  fix: Fixed broken tenant ID on save (microsoft#6809)
  feat: Add devops and app insights to get started (microsoft#6790)
  fix: check for node on app start on users machine and notify if not installed (microsoft#6578)
  feat: Expose default search query, pre-release flag and type for each feed. (microsoft#6781)
  fix: do not provision an endpoint key (microsoft#6791)
  remove folder if project fails to create (microsoft#6793)
  Removed preview from publish type names (microsoft#6795)
  fix: Fixing deep link for QNA and Luis (microsoft#6743)
  Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (microsoft#6788)
  Added workerRuntime value (microsoft#6784)
  fix: apply publishing profile to new runtime during publish (microsoft#6719)
  fix: during publish, do not copy project into a build folder (microsoft#6729)
  chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (microsoft#6697)
  polish UI
  remove trigger when remove skill, fix bugs
  fix orchestractor modal not show
  fix skill not added after add remote skill
  remove allowedCaller when remove skill
  ...
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
@alanlong9278
Merge branch 'main' into qika/skill
016a223 
* main:
  fix: make composer support https proxy (microsoft#6766)
  Force refresh of fluent List via slice (microsoft#6810)
  fix: Telemetry for Orchestrator R13 (microsoft#6689)
  fix: Fixed broken tenant ID on save (microsoft#6809)
  feat: Add devops and app insights to get started (microsoft#6790)
  fix: check for node on app start on users machine and notify if not installed (microsoft#6578)
  feat: Expose default search query, pre-release flag and type for each feed. (microsoft#6781)
  fix: do not provision an endpoint key (microsoft#6791)
  remove folder if project fails to create (microsoft#6793)
  Removed preview from publish type names (microsoft#6795)
  fix: Fixing deep link for QNA and Luis (microsoft#6743)
  Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (microsoft#6788)
  Added workerRuntime value (microsoft#6784)
  fix: apply publishing profile to new runtime during publish (microsoft#6719)
  fix: during publish, do not copy project into a build folder (microsoft#6729)
  chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (microsoft#6697)
benbrown pushed a commit that referenced this pull request Jun 11, 2021
@alanlong9278
Merge branch 'wenyluo/skill' into julong/skill
2504e8b 
* wenyluo/skill: (30 commits)
  Force refresh of fluent List via slice (#6810)
  fix: Telemetry for Orchestrator R13 (#6689)
  fix: Fixed broken tenant ID on save (#6809)
  feat: Add devops and app insights to get started (#6790)
  fix: check for node on app start on users machine and notify if not installed (#6578)
  feat: Expose default search query, pre-release flag and type for each feed. (#6781)
  fix: do not provision an endpoint key (#6791)
  remove folder if project fails to create (#6793)
  Removed preview from publish type names (#6795)
  fix: Fixing deep link for QNA and Luis (#6743)
  Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (#6788)
  Added workerRuntime value (#6784)
  fix: apply publishing profile to new runtime during publish (#6719)
  fix: during publish, do not copy project into a build folder (#6729)
  chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (#6697)
  polish UI
  remove trigger when remove skill, fix bugs
  fix orchestractor modal not show
  fix skill not added after add remote skill
  remove allowedCaller when remove skill
  ...
benbrown pushed a commit that referenced this pull request Jun 11, 2021
@alanlong9278
Merge branch 'main' into qika/skill
cbeeeee 
* main:
  fix: make composer support https proxy (#6766)
  Force refresh of fluent List via slice (#6810)
  fix: Telemetry for Orchestrator R13 (#6689)
  fix: Fixed broken tenant ID on save (#6809)
  feat: Add devops and app insights to get started (#6790)
  fix: check for node on app start on users machine and notify if not installed (#6578)
  feat: Expose default search query, pre-release flag and type for each feed. (#6781)
  fix: do not provision an endpoint key (#6791)
  remove folder if project fails to create (#6793)
  Removed preview from publish type names (#6795)
  fix: Fixing deep link for QNA and Luis (#6743)
  Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (#6788)
  Added workerRuntime value (#6784)
  fix: apply publishing profile to new runtime during publish (#6719)
  fix: during publish, do not copy project into a build folder (#6729)
  chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (#6697)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@carlosscastro @beyackle @cwhitten
chore: Adapters: copy the 'type' passed in the adapter config to full…
c40001e 
…y support adapter schemas (microsoft#6697)

* Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas

* adapters: update tests part 1

Co-authored-by: Ben Yackley <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beyackle beyackle beyackle left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@beyackle beyackle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carlosscastro @a-b-r-o-w-n @coveralls @beyackle @cwhitten