Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make composer support https proxy #6766

Merged
merged 3 commits into from
Apr 9, 2021
Merged

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Apr 8, 2021

Description

Fixed
update the bf-lu package version to make luis and qna publish support proxy. (wait for the npm package)

Need to fix

  1. create bot
  2. azure login
  3. auth related

These three stages still don't support the proxy now. These maybe related to the node-fetch package.

Task Item

#minor

Screenshots

@lei9444 lei9444 marked this pull request as ready for review April 9, 2021 03:42
@coveralls
Copy link

coveralls commented Apr 9, 2021

Coverage Status

Coverage remained the same at 51.141% when pulling 0ae15d8 on lei9444:proxy into 1838c34 on microsoft:main.

@boydc2014 boydc2014 merged commit 683520a into microsoft:main Apr 9, 2021
alanlong9278 added a commit that referenced this pull request Apr 9, 2021
* main:
  fix: make composer support https proxy (#6766)
  Force refresh of fluent List via slice (#6810)
  fix: Telemetry for Orchestrator R13 (#6689)
  fix: Fixed broken tenant ID on save (#6809)
  feat: Add devops and app insights to get started (#6790)
  fix: check for node on app start on users machine and notify if not installed (#6578)
  feat: Expose default search query, pre-release flag and type for each feed. (#6781)
  fix: do not provision an endpoint key (#6791)
  remove folder if project fails to create (#6793)
  Removed preview from publish type names (#6795)
  fix: Fixing deep link for QNA and Luis (#6743)
  Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (#6788)
  Added workerRuntime value (#6784)
  fix: apply publishing profile to new runtime during publish (#6719)
  fix: during publish, do not copy project into a build folder (#6729)
  chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (#6697)
alanlong9278 added a commit that referenced this pull request Apr 9, 2021
* qika/skill:
  tooltip
  fix: bot can't start or publish by cleaning unused code (#6816)
  fix: make composer support https proxy (#6766)
@cwhitten cwhitten mentioned this pull request May 20, 2021
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
* main:
  fix: make composer support https proxy (microsoft#6766)
  Force refresh of fluent List via slice (microsoft#6810)
  fix: Telemetry for Orchestrator R13 (microsoft#6689)
  fix: Fixed broken tenant ID on save (microsoft#6809)
  feat: Add devops and app insights to get started (microsoft#6790)
  fix: check for node on app start on users machine and notify if not installed (microsoft#6578)
  feat: Expose default search query, pre-release flag and type for each feed. (microsoft#6781)
  fix: do not provision an endpoint key (microsoft#6791)
  remove folder if project fails to create (microsoft#6793)
  Removed preview from publish type names (microsoft#6795)
  fix: Fixing deep link for QNA and Luis (microsoft#6743)
  Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (microsoft#6788)
  Added workerRuntime value (microsoft#6784)
  fix: apply publishing profile to new runtime during publish (microsoft#6719)
  fix: during publish, do not copy project into a build folder (microsoft#6729)
  chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (microsoft#6697)
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
* qika/skill:
  tooltip
  fix: bot can't start or publish by cleaning unused code (microsoft#6816)
  fix: make composer support https proxy (microsoft#6766)
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* main:
  fix: make composer support https proxy (#6766)
  Force refresh of fluent List via slice (#6810)
  fix: Telemetry for Orchestrator R13 (#6689)
  fix: Fixed broken tenant ID on save (#6809)
  feat: Add devops and app insights to get started (#6790)
  fix: check for node on app start on users machine and notify if not installed (#6578)
  feat: Expose default search query, pre-release flag and type for each feed. (#6781)
  fix: do not provision an endpoint key (#6791)
  remove folder if project fails to create (#6793)
  Removed preview from publish type names (#6795)
  fix: Fixing deep link for QNA and Luis (#6743)
  Make LUIS, QNA and Speech blocking modals so they cannot be dismiessed while active (#6788)
  Added workerRuntime value (#6784)
  fix: apply publishing profile to new runtime during publish (#6719)
  fix: during publish, do not copy project into a build folder (#6729)
  chore: Adapters: copy the 'type' passed in the adapter config to fully support adapter schemas (#6697)
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* qika/skill:
  tooltip
  fix: bot can't start or publish by cleaning unused code (#6816)
  fix: make composer support https proxy (#6766)
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* fix: make composer support https proxy

* update the bf-lu version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants