Fix accessibility issues due to aria-hidden and aria-labelledby in FileContent and CarouselFilmStrip #3836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
aria-hidden
from elements that have a focusable child, by @corinagum in PR #3836aria-labelledby
from carousel, by @corinagum in PR #3836Description
This contains a few accessibility fixes when running FastPass on Web Chat.
Specific Changes
#3810 - Ensures aria-hidden elements do not contain focusable elements
FileContent.js
: Addaria-label
alt
text to download link, which was previously not being read.FileContent.js
: Remove erroneousaria-hidden=true
FileContent.js
: Remove<ScreenReaderText />
#3811 - Ensure all ARIA attributes have valid values
CarouselFilmStrip.js
- remove erroneousaria-labelledby
attributearia-labelledby
is intended for visible text attributed as the labelCHANGELOG.md
I have updated documentationReview Checklist
z-index
)package.json
andpackage-lock.json
reviewed