-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow carousel's scrollable content to be tab-able with visual focus #3841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
beyackle,
compulim,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
April 9, 2021 23:45
corinagum
commented
Apr 10, 2021
corinagum
commented
Apr 10, 2021
corinagum
commented
Apr 10, 2021
3836 is merged |
compulim
reviewed
Apr 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some work to make it conform with CSS BEM.
compulim
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
packages/component/src/Styles/StyleSet/CarouselFilmStripAttachment.ts
Outdated
Show resolved
Hide resolved
packages/component/src/Styles/StyleSet/CarouselFilmStripAttachment.ts
Outdated
Show resolved
Hide resolved
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
Carousel focus on children needed to be added in order to allow tabbing and AT to read contents.
Focus style will match from the following variables:
transcriptVisualKeyboardIndicatorColor
transcriptVisualKeyboardIndicatorStyle
transcriptVisualKeyboardIndicatorWidth
Specific Changes
#3814 - Allow carousel's scrollable content to be tab-able with visual focus
#3835 - Ensure carousel attachments are read by AT on focus
[Other]
CODEOWNERS
focusManagement.(...).html
testCHANGELOG.md
Review Checklist
z-index
)package.json
andpackage-lock.json
reviewed