Increase error threshold for batch length (#10336)

microsoft · May 19, 2022 · 50c4507 · 50c4507
1 parent 924a033
commit 50c4507
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 24 deletions.
diff --git a/experimental/dds/tree/src/test/Virtualization.tests.ts b/experimental/dds/tree/src/test/Virtualization.tests.ts
@@ -210,19 +210,11 @@ describe('SharedTree history virtualization', () => {
 	});
 
 	it('can upload full chunks with incomplete chunks in the edit log', async () => {
-		testObjectProvider.logger.registerExpectedEvent(
-			{ eventName: 'fluid:telemetry:Batching:LengthTooBig' },
-			{ eventName: 'fluid:telemetry:Batching:LengthTooBig' }
-		);
 		await addNewEditChunks(1, 50);
 		expect(editChunksUploaded).to.equal(1);
 	});
 
 	it('correctly saves handles and their corresponding starting revisions to the summary', async () => {
-		testObjectProvider.logger.registerExpectedEvent(
-			{ eventName: 'fluid:telemetry:Batching:LengthTooBig' },
-			{ eventName: 'fluid:telemetry:Batching:LengthTooBig' }
-		);
 		await addNewEditChunks(4);
 
 		const { editHistory } = sharedTree.saveSummary() as SharedTreeSummary;
@@ -278,11 +270,6 @@ describe('SharedTree history virtualization', () => {
 	});
 
 	it('does not cause misaligned chunks', async () => {
-		testObjectProvider.logger.registerExpectedEvent(
-			{ eventName: 'fluid:telemetry:Batching:LengthTooBig' },
-			{ eventName: 'fluid:telemetry:Batching:LengthTooBig' },
-			{ eventName: 'fluid:telemetry:Batching:LengthTooBig' }
-		);
 		await addNewEditChunks(1, 50);
 
 		const summary = sharedTree.saveSummary();
@@ -309,11 +296,6 @@ describe('SharedTree history virtualization', () => {
 
 	it('does not cause misaligned chunks for format version 0.0.2', async () => {
 		await useSharedTreeSummaryv0_0_2();
-		testObjectProvider.logger.registerExpectedEvent(
-			{ eventName: 'fluid:telemetry:Batching:LengthTooBig' },
-			{ eventName: 'fluid:telemetry:Batching:LengthTooBig' },
-			{ eventName: 'fluid:telemetry:Batching:LengthTooBig' }
-		);
 
 		// Add enough edits for a chunk and a half
 		await addNewEditChunks(1, 50);

diff --git a/experimental/dds/tree/src/test/utilities/SharedTreeTests.ts b/experimental/dds/tree/src/test/utilities/SharedTreeTests.ts
@@ -1322,11 +1322,6 @@ export function runSharedTreeOperationsTests(
 				writeFormat,
 				summarizeHistory: false,
 			});
-			testObjectProvider.logger.registerExpectedEvent(
-				{ eventName: 'fluid:telemetry:Batching:LengthTooBig' },
-				{ eventName: 'fluid:telemetry:Batching:LengthTooBig' },
-				{ eventName: 'fluid:telemetry:Batching:LengthTooBig' }
-			);
 
 			applyNoop(tree);
 			await testObjectProvider.ensureSynchronized();

diff --git a/packages/runtime/container-runtime/src/batchTracker.ts b/packages/runtime/container-runtime/src/batchTracker.ts
@@ -75,6 +75,6 @@ export class BatchTracker {
 export const BindBatchTracker = (
     batchEventEmitter: EventEmitter,
     logger: ITelemetryLogger,
-    batchLengthThreshold: number = 128,
+    batchLengthThreshold: number = 1000,
     batchCountSamplingRate: number = 1000,
 ) => new BatchTracker(batchEventEmitter, logger, batchLengthThreshold, batchCountSamplingRate);