Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase error threshold for batch length #10336

Merged
merged 4 commits into from
May 19, 2022

Conversation

andre4i
Copy link
Contributor

@andre4i andre4i commented May 18, 2022

286

union Office_Fluid_FluidRuntime_*
| where Data_eventName == "fluid:telemetry:Batching:LengthTooBig" and Data_length >= 1000
| project Event_Time, Data_docId, Data_eventName, Data_hostName, Data_clientType, Data_batchError, Data_length, Data_threshold, Data_duration

There are a lot of instances with unrealistic batch lengths. I believe the problem is using message.sequenceNumber instead of message.clientSequenceNumber when computing the batch length For batches, both numbers have the same semantics. Also, increasing the threshold to 1000.

@andre4i andre4i requested review from a team as code owners May 18, 2022 23:37
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: runtime Runtime related issues base: main PRs targeted against main branch labels May 18, 2022
@vladsud
Copy link
Contributor

vladsud commented May 19, 2022

There are a lot of instances with unrealistic batch lengths. I believe the problem is using message.sequenceNumber instead of message.clientSequenceNumber when computing the batch length.

There should be no difference. We should add assert for it and not care what we use.

@andre4i andre4i changed the title Increase error threshold for batch length, use clientSequenceNumber Increase error threshold for batch length May 19, 2022
@andre4i andre4i merged commit 50c4507 into microsoft:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds Issues related to distributed data structures area: runtime Runtime related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants