Skip to content

Commit

Permalink
Remove closing summarizer on stale events (#17801)
Browse files Browse the repository at this point in the history
[AB#5146](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/5146)

Originally this was added to differentiate between the Refresh from
Server code and the Close Code which has already been removed:
#16657, as we always
close.

The information this event is already contained in both
`RefreshLatestSummaryFromServerFetch_end` and during `Summarize_cancel`.

Remove ClosingSummarizerOnSummaryStale telemetry as it is duplicate to
both `RefreshLatestSummaryFromServerFetch_end` and
`RefreshLatestSummaryAckFetch_end` telemetry
  • Loading branch information
tyler-cai-microsoft authored Oct 17, 2023
1 parent 3073fc0 commit c14ea4f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 22 deletions.
10 changes: 0 additions & 10 deletions packages/runtime/container-runtime/src/containerRuntime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3814,16 +3814,6 @@ export class ContainerRuntime
}

private async closeStaleSummarizer(codePath: string): Promise<void> {
this.mc.logger.sendTelemetryEvent(
{
eventName: "ClosingSummarizerOnSummaryStale",
codePath,
message: "Stopping fetch from storage",
closeSummarizerDelayMs: this.closeSummarizerDelayMs,
},
new GenericError("Restarting summarizer instead of refreshing"),
);

// Delay before restarting summarizer to prevent the summarizer from restarting too frequently.
await delay(this.closeSummarizerDelayMs);
this._summarizer?.stop("latestSummaryStateStale");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ describeNoCompat("Summarizer closes instead of refreshing", (getTestObjectProvid
eventName:
"fluid:telemetry:Summarizer:Running:RefreshLatestSummaryFromServerFetch_end",
},
{
eventName: "fluid:telemetry:ContainerRuntime:ClosingSummarizerOnSummaryStale",
},
{
eventName: "fluid:telemetry:Container:ContainerDispose",
category: "generic",
Expand Down Expand Up @@ -85,9 +82,6 @@ describeNoCompat("Summarizer closes instead of refreshing", (getTestObjectProvid
{
eventName: "fluid:telemetry:SummarizerNode:refreshLatestSummary_end",
},
{
eventName: "fluid:telemetry:ContainerRuntime:ClosingSummarizerOnSummaryStale",
},
{
eventName: "fluid:telemetry:Container:ContainerDispose",
category: "generic",
Expand Down Expand Up @@ -123,9 +117,6 @@ describeNoCompat("Summarizer closes instead of refreshing", (getTestObjectProvid
itExpects(
"Closes the summarizing client instead of refreshing when loading from an older summary",
[
{
eventName: "fluid:telemetry:ContainerRuntime:ClosingSummarizerOnSummaryStale",
},
{
eventName: "fluid:telemetry:Container:ContainerDispose",
category: "generic",
Expand Down Expand Up @@ -178,9 +169,6 @@ describeNoCompat("Summarizer closes instead of refreshing", (getTestObjectProvid
eventName:
"fluid:telemetry:Summarizer:Running:RefreshLatestSummaryFromServerFetch_end",
},
{
eventName: "fluid:telemetry:ContainerRuntime:ClosingSummarizerOnSummaryStale",
},
{
eventName: "fluid:telemetry:Container:ContainerDispose",
category: "generic",
Expand Down

0 comments on commit c14ea4f

Please sign in to comment.