Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove closing summarizer on stale events #17801

Conversation

tyler-cai-microsoft
Copy link
Contributor

@tyler-cai-microsoft tyler-cai-microsoft commented Oct 16, 2023

AB#5146

Originally this was added to differentiate between the Refresh from Server code and the Close Code which has already been removed: #16657, as we always close.

The information this event is already contained in both RefreshLatestSummaryFromServerFetch_end and during Summarize_cancel.

Remove ClosingSummarizerOnSummaryStale telemetry as it is duplicate to both RefreshLatestSummaryFromServerFetch_end and RefreshLatestSummaryAckFetch_end telemetry

@tyler-cai-microsoft tyler-cai-microsoft requested review from a team as code owners October 16, 2023 22:27
@github-actions github-actions bot added area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Oct 16, 2023
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: -468 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 445.22 KB 444.99 KB -234 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 238.37 KB 238.14 KB -234 Bytes
loader.js 178.25 KB 178.25 KB No change
map.js 48.06 KB 48.06 KB No change
matrix.js 141.84 KB 141.84 KB No change
odspDriver.js 90.24 KB 90.24 KB No change
odspPrefetchSnapshot.js 41.75 KB 41.75 KB No change
sharedString.js 162.68 KB 162.68 KB No change
sharedTree2.js 266.54 KB 266.54 KB No change
Total Size 1.72 MB 1.72 MB -468 Bytes

Baseline commit: d0532c6

Generated by 🚫 dangerJS against 6a7642b

@tyler-cai-microsoft tyler-cai-microsoft merged commit c14ea4f into microsoft:main Oct 17, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants