Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo policy improvements #9982

Closed
tylerbutler opened this issue Apr 20, 2022 · 1 comment
Closed

Repo policy improvements #9982

tylerbutler opened this issue Apr 20, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@tylerbutler
Copy link
Member

This issue tracks policies that we could/should enforce in the repo.

  1. No extraneous package-lock.json files. See delete package locks which are out of date, and can not be installed #9956.
  2. Use tilde (~) dependencies for TypeScript and ESLint. See this comment
  3. No rules set to 'off' in eslint project-level overrides.
@ghost
Copy link

ghost commented Oct 18, 2022

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed Oct 26, 2022
tylerbutler added a commit that referenced this issue Nov 1, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…12724)

Some libraries we depend on, like typescript and eslint, recommend using
tilde dependencies instead of caret because they do introduce breaking
changes in minor versions. This change adds a policy handler to enforce
it.

More discussion at
<#9966 (comment)>
and in <#9982>.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant