Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete package locks which are out of date, and can not be installed #9956

Merged
merged 1 commit into from
Apr 19, 2022
Merged

delete package locks which are out of date, and can not be installed #9956

merged 1 commit into from
Apr 19, 2022

Conversation

CraigMacomber
Copy link
Contributor

Delete package lock files from inner packages which are unable to be installed (npm install fails).

The error in each is something like:
"No matching version found for @fluidframework/test-runtime-utils@^0.59.2000"

It seems that these package lock files are not used by our build or tests, and are also out of date.

It is unclear to me if these were intended to be kept up to date and that failed, or if they should never have existed in the first place: either way they are no functional and do not seem to offer any value currently.

@CraigMacomber CraigMacomber requested review from a team as code owners April 18, 2022 23:28
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: examples Changes that focus on our examples base: main PRs targeted against main branch labels Apr 18, 2022
@CraigMacomber CraigMacomber merged commit 05a7a93 into microsoft:main Apr 19, 2022
@tylerbutler tylerbutler mentioned this pull request Apr 20, 2022
Closed
@tylerbutler tylerbutler mentioned this pull request Oct 29, 2022
Merged
tylerbutler added a commit that referenced this pull request Nov 1, 2022
@tylerbutler
feat(check:policy): Add policy handler to check for extraneous lockfi…
a477941 
…les (#12726)

Adds a policy handler that checks that package-lock.json files appear
only in the root of release groups or independent packages. Additional
paths can be added to the fluidBuild.additionalLockfilePaths array in
package.json.

Related to #9956.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-murphy anthony-murphy anthony-murphy approved these changes

Assignees
No one assigned
Labels
area: dds: propertydds area: dds Issues related to distributed data structures area: examples Changes that focus on our examples base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CraigMacomber @anthony-murphy