Remove deprecated container connection APIs #10192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
base: next
|
This PR is currently running into compat test issues due to the current LTS version: @anthony-murphy, do you have any info/docs on how LTS versioning works? I'd love some more context to help determine what my next steps should be. cc @skylerjokiel |
markfields
reviewed
May 17, 2022
markfields
reviewed
May 26, 2022
markfields
reviewed
May 26, 2022
markfields
reviewed
May 26, 2022
markfields
reviewed
May 26, 2022
markfields
reviewed
May 26, 2022
markfields
reviewed
May 26, 2022
There was a problem hiding this comment.
This will be great to get fully transitioned to the new APIs!
Couple things before signing off:
- I noticed none of these deprecated APIs have been cleaned up in the Loop codebase yet. Did we get an "upcoming" notification out in a previous release that communicated when they'd be removed? Do they have a task on their side tracking the migration work? If not we might want to wait and not remove these in 1.0. Or, if we are sufficiently motivated we could go make the changes in their code to ease the burden during FF bump (goal is to have the FF bump be a no-op by communicating enough for them to plan ahead)
- Take a look at my comment around duplicating
waitContainerToCatchUp, I had another idea that might work without the duplicated code.
@markfields, these changes were only communicated in BREAKING.md. I don't think it would be very difficult to make the changes, so I'm leaning towards doing it myself. |
markfields
reviewed
May 26, 2022
markfields
reviewed
May 27, 2022
| @@ -76,8 +76,10 @@ | |||
| "ClassDeclaration_SharedDirectory": {"forwardCompat": false}, | |||
| "ClassDeclaration_SharedString": {"forwardCompat": false}, | |||
| "ClassDeclaration_FluidContainer": {"forwardCompat": false, "backCompat": false}, | |||
| "InterfaceDeclaration_IFluidContainer": {"backCompat": false} | |||
| }, | |||
| "disabled": true | |||
There was a problem hiding this comment.
This also confused me 😅. I'm not sure exactly what happened, but when I merged the latest changes from the next branch, I noticed that there was a merge conflict here with "disabled": true. I checked both this branch and the next branch and it seemed to not exist on either. Either way I think we should be fine now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the APIs deprecated in 0.58 via #9439, which include
Container.setAutoReconnect(),Container.resume(),IContainer.connected, andIFluidContainer.connected.Additionally, this PR replaces any remaining usages/references of the above APIs with their respective replacements (see #9167).
Closes #9397