Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(build-tools): Downgrade lerna to v4 #12563

Merged
merged 1 commit into from
Oct 18, 2022
Merged

build(build-tools): Downgrade lerna to v4 #12563

merged 1 commit into from
Oct 18, 2022

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Oct 18, 2022 •
edited
Loading

This partially reverts commit 5978e0c.

The lerna update is the current suspect in some installation problems that people are seeing with the latest build-tools releases. The errors manifest like this:

npm WARN [email protected] requires a peer of ajv@^6.9.1 but none is installed. You must install peer dependencies yourself.

npm ERR! code ENOENT
npm ERR! syscall chmod
npm ERR! path /usr/local/share/nvm/versions/node/v14.20.1/lib/node_modules/@fluid-tools/build-cli/node_modules/@npmcli/installed-package-contents/index.js
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, chmod '/usr/local/share/nvm/versions/node/v14.20.1/lib/node_modules/@fluid-tools/build-cli/node_modules/@npmcli/installed-package-contents/index.js'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

When trying to install globally.

@tylerbutler tylerbutler marked this pull request as ready for review October 18, 2022 23:01
@tylerbutler tylerbutler requested review from msfluid-bot and a team as code owners October 18, 2022 23:01
@github-actions github-actions bot added the base: main PRs targeted against main branch label Oct 18, 2022
@tylerbutler tylerbutler merged commit a6191f7 into microsoft:main Oct 18, 2022
@tylerbutler tylerbutler deleted the cli/install-fix branch October 18, 2022 23:17
tylerbutler added a commit that referenced this pull request Oct 19, 2022
@tylerbutler
Revert "build(build-tools): Downgrade lerna to v4 (#12563)"
fa69974 
This reverts commit a6191f7.
@tylerbutler tylerbutler mentioned this pull request Oct 19, 2022
Merged
tylerbutler added a commit that referenced this pull request Oct 19, 2022
@tylerbutler
revert(build-tools): revert downgrade lerna to v4 (#12580)
a9b0650 
This reverts commit a6191f7; PR #12563.

The installation problem we were seeing with the build-cli package was
due to another dependency, not lerna. Thus, this PR reverts the previous
partial revert, restoring lerna to v5 in build-tools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markfields markfields markfields approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

Assignees
No one assigned
Labels
base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerbutler @markfields