feat(check:policy): Add policy handler to check for extraneous lockfiles #12726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbutler
commented
Oct 29, 2022
tylerbutler
changed the title
curtisman
reviewed
Oct 31, 2022
build-tools/packages/build-tools/src/repoPolicyCheck/handlers/lockfiles.ts
Outdated
Show resolved
Hide resolved
curtisman
reviewed
Oct 31, 2022
| if (Array.isArray(arr)) { | ||
| knownPaths.push(...arr.map((p) => p.toString())); | ||
| } | ||
| } |
There was a problem hiding this comment.
The above seems compute the same thing again and again. Should we cache it?
There was a problem hiding this comment.
Refactored this out into a get function that calculates the known paths once and returns the cached value subsequently.
tylerbutler
force-pushed
the
cli/lockfile-policy
branch
from
806916e to
bdf5bed
Compare
curtisman
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a policy handler that checks that package-lock.json files appear only in the root of release groups or independent packages. Additional paths can be added to the fluidBuild.additionalLockfilePaths array in package.json.
Related to #9956.