Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Input to rehydrateDetachedContainerFromSnapshot #17706

Merged

Conversation

anthony-murphy
Copy link
Contributor

Validates that the string passed to rehydrateDetachedContainerFromSnapshot is of the correct format, rather than assuming via cast which can lead to random failures. Also add a unit test to verify the validation

@anthony-murphy anthony-murphy requested review from a team as code owners October 10, 2023 23:35
@github-actions github-actions bot added area: loader Loader related issues area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API base: main PRs targeted against main branch labels Oct 10, 2023
@github-actions github-actions bot removed the area: tests Tests to add, test infrastructure improvements, etc label Oct 10, 2023
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Oct 11, 2023

@fluid-example/bundle-size-tests: +116 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 445.22 KB 445.22 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 238.37 KB 238.37 KB No change
loader.js 178.16 KB 178.25 KB +83 Bytes
map.js 48.06 KB 48.06 KB No change
matrix.js 141.84 KB 141.84 KB No change
odspDriver.js 90.21 KB 90.24 KB +33 Bytes
odspPrefetchSnapshot.js 41.75 KB 41.75 KB No change
sharedString.js 162.68 KB 162.68 KB No change
sharedTree2.js 266.3 KB 266.3 KB No change
Total Size 1.72 MB 1.72 MB +116 Bytes

Baseline commit: b856d87

Generated by 🚫 dangerJS against 0d41cd7

@anthony-murphy anthony-murphy merged commit eebb3b2 into microsoft:main Oct 16, 2023
@anthony-murphy anthony-murphy deleted the validate-rehdration-input branch October 16, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: loader Loader related issues base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants