-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace copyContainer with viewContainerVersion #20779
Conversation
⯆ @fluid-example/bundle-size-tests: -104 Bytes
Baseline commit: eda9e6d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
id: string, | ||
containerSchema: TContainerSchema, | ||
version: AzureContainerVersion, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "version" being used at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, I accidentally broke it when switching to the new API in the last commit. Fixed in latest.
@ChumpChief were you able to validate full recovery flow? Also please open the ADO item that tracks work needed to updated service docs showing the recovery workflow. Maybe we need to chat with them how their docs are distinguishing 1.x and 2.x scenarios. |
@@ -0,0 +1,8 @@ | |||
--- | |||
"@fluidframework/azure-client": minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be a major change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe @tylerbutler 's guidance was to just leave as minor since we don't use changeset
to version our packages.
Yes, I did manual verification that I could get versions, use the new API to load from those versions, and retrieve the data (and that the data was in the prior state). EDIT: Also just retested this using the new
Opened AB#7917 |
The copyContainer API did not properly handle scenarios where the sequenceNumber from the old container was present in the summary that was used to establish the new container. In this case, the document was corrupted due to a "sequenceNumber from the future" breaking expectations. In 2.0, there is additionally an assert that blocks attempting the copy altogether (added in #17706).
This PR moves away from the copyContainer approach in favor of just loading the historic version for viewing - the customer can then decide what to do with the data. Most likely usage pattern would be:
AB#6411
AB#7712