Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove closing summarizer on stale events #17801

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Remove closing summarizer on stale events #17801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions packages/runtime/container-runtime/src/containerRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3814,16 +3814,6 @@ export class ContainerRuntime
}

private async closeStaleSummarizer(codePath: string): Promise<void> {
this.mc.logger.sendTelemetryEvent(
{
eventName: "ClosingSummarizerOnSummaryStale",
codePath,
message: "Stopping fetch from storage",
closeSummarizerDelayMs: this.closeSummarizerDelayMs,
},
new GenericError("Restarting summarizer instead of refreshing"),
);

// Delay before restarting summarizer to prevent the summarizer from restarting too frequently.
await delay(this.closeSummarizerDelayMs);
this._summarizer?.stop("latestSummaryStateStale");
Expand Down
12 changes: 0 additions & 12 deletions packages/test/test-end-to-end-tests/src/test/summarizeRestart.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ describeNoCompat("Summarizer closes instead of refreshing", (getTestObjectProvid
eventName:
"fluid:telemetry:Summarizer:Running:RefreshLatestSummaryFromServerFetch_end",
},
{
eventName: "fluid:telemetry:ContainerRuntime:ClosingSummarizerOnSummaryStale",
},
{
eventName: "fluid:telemetry:Container:ContainerDispose",
category: "generic",
Expand Down Expand Up @@ -85,9 +82,6 @@ describeNoCompat("Summarizer closes instead of refreshing", (getTestObjectProvid
{
eventName: "fluid:telemetry:SummarizerNode:refreshLatestSummary_end",
},
{
eventName: "fluid:telemetry:ContainerRuntime:ClosingSummarizerOnSummaryStale",
},
{
eventName: "fluid:telemetry:Container:ContainerDispose",
category: "generic",
Expand Down Expand Up @@ -123,9 +117,6 @@ describeNoCompat("Summarizer closes instead of refreshing", (getTestObjectProvid
itExpects(
"Closes the summarizing client instead of refreshing when loading from an older summary",
[
{
eventName: "fluid:telemetry:ContainerRuntime:ClosingSummarizerOnSummaryStale",
},
{
eventName: "fluid:telemetry:Container:ContainerDispose",
category: "generic",
Expand Down Expand Up @@ -178,9 +169,6 @@ describeNoCompat("Summarizer closes instead of refreshing", (getTestObjectProvid
eventName:
"fluid:telemetry:Summarizer:Running:RefreshLatestSummaryFromServerFetch_end",
},
{
eventName: "fluid:telemetry:ContainerRuntime:ClosingSummarizerOnSummaryStale",
},
{
eventName: "fluid:telemetry:Container:ContainerDispose",
category: "generic",
Expand Down