[PT Run] [WindowWalker] Process ID is zero for win32 apps

[htcfreek]

Microsoft PowerToys version

0.53.1

Running as admin

• Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

While working on the code for #6084 I detected that the process ID of the detected windows is incorrect/zero. It only happens on non-packaged apps.

Note: I use the NativeMethods.cs from PR #15186.

✔️ Expected Behavior

Correct PID.

❌ Actual Behavior

It is incorrect for non-packaged apps:

It is correct for packaged apps and the process that is shown for it:

Other Software

No response

[htcfreek]

@davidegiacometti
Do you have an idea why the PID for win32 apps is only available if I add this additional assignment (5b9b632)? For title and process name it works as expected without such an assignment.

[davidegiacometti]

@davidegiacometti Do you have an idea why the PID for win32 apps is only available if I add this additional assignment (5b9b632)? For title and process name it works as expected without such an assignment.

Not sure. Does it happen with programs that aren't running elevated?

[htcfreek]

@davidegiacometti Do you have an idea why the PID for win32 apps is only available if I add this additional assignment (5b9b632)? For title and process name it works as expected without such an assignment.

Not sure. Does it happen with programs that aren't running elevated?

every one. I don't understand why it's gone and only for win32. It seems that we instantiate the windows on every query but keep the window cache as static class variable.
The debug output show that it is set and gets lost at some point. 🤨

Maybe we should look when the windows gets instanced and maybe we should rework the entire class.

I don't like the fix I have added. It feels a bit ugly.

[htcfreek]

@davidegiacometti Do you have an idea why the PID for win32 apps is only available if I add this additional assignment (5b9b632)? For title and process name it works as expected without such an assignment.

Not sure. Does it happen with programs that aren't running elevated?

every one. I don't understand why it's gone and only for win32. It seems that we instantiate the windows on every query but keep the window cache as static class variable.
The debug output show that it is set and gets lost at some point. 🤨

Maybe we should look when the windows gets instanced and maybe we should rework the entire class.

I don't like the fix I have added. It feels a bit ugly.

@davidegiacometti
I have looked into it. I will rework some parts of the class (process name, PID detection).

[htcfreek]

@davidegiacometti
I have improved the code and now it works as expected. And it seems that the plugin works now faster. ;-)

[htcfreek]

@crutkas
Please update the assigned project.

[Aaron-Junker]

@htcfreek done

[crutkas]

The was fixed in in 0.55. Head over to https://aka.ms/installpowertoys to try it out