[PT Run] WindowWalker: Refactor code, fix some bugs, hide UWP non-windows, prepare code for new features #15441

htcfreek · 2022-01-11T12:36:26Z

Note: This is a follow up of the closed PR #15329 which had merge mistakes.

Summary of the Pull Request

What is this about:
This PR prepares the implementation of two new features into WindowWalker. They are asked in issue #6084:

Close the window.
Kill the window process/app.

For this new features we need some code changes and additional information about a window/app. And there are some bugs we should fix before implementing the new features.

What is included in this PR:
Code refactoring:

Refactor of the Window.cs class, implementation of a new WindowProcess.cs class and improvements to the process cache data to have less queries for static information.
Moving process information and code into own class.
Filter child window of AppFrameHost.exe by class instead of process id.
Improve SearchController.cs class to speed up search times.

Requirements for new features and fixes:

Adding additional properties for the WindowProcess (class): ThreadId, IsFullAccessDenied, IsUwpApp, DoesExist, IsShellProcess
Adding additional properties to Window class: CloakedState, IsCloaked

Fixes:

A fix for the PID which is zero for win32 applications.
Improved detection of process ID and thread ID
Ignore cloaked uwp non-windows in result list.
We now closing process handles we don't need anymore.

Remarks:

For debugging and testing I have added a tool-tip.

How does someone test / validate:

General changes: Build local and validate information in tool tip.

Speed improvements:
System for test before improvement: Win10 Pro; 2 core [Intel i7-Intel(R) Core(TM) i7-10875H CPU @ 2.30GHz]; Ram 4,0 GB (used: ?? GB) => Times from older logs with less open windows.
System for test after improvement: Win10 Pro; 1 core [Intel i7-Intel(R) Core(TM) i7-10875H CPU @ 2.30GHz]; Ram 2,0 GB (used: 1,7 GB)
Open windows: 65 (explorer: 20, Calculator: 20, Editor: 20, Other windows: 5)
Search term: "<explorer"

QueryTimeTestLog.txt

Query remarks	Before code improvements	After code improvements
After cold start of PT	up to 1900 ms	Up to 25 ms
On Hotkey invoke (second time)	Up to 800 ms	Up to 5 ms

Screenshots:

Tool tip with debug information:

We now can check if the process of a window equals the shell process (taskbar, start menu, ...):

Properties of an hidden (preloaded) uwp app window:

Now hidden uwp app windows aren't shown anymore:

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

github-actions · 2022-01-11T12:38:36Z

@check-spelling-bot Report

🔴 Please review

See the files view or the action log for details.

Unrecognized words (3)

Hostbackdropbrush
Tickness
Visibel

Previously acknowledged words that are now absent

ChaseKnowlden CleanCodeDeveloper CTLCOLORSTATIC Deuchert efgh errc Grayscale iccex ICONINFORMATION INITCOMMONCONTROLSEX INSTALLLOGATTRIBUTES INSTALLLOGMODE INSTALLUILEVEL MAINICON MAKELPARAM msiexec MSIINSTALLER NATIVEFNTCTL netlify Qin rdeveen rexit SETRANGE SETSTEP sregex STEPIT symlink UITo We'd

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the [email protected]:htcfreek/PowerToys.git repository
on the PT_ImproveWwNew branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/whitelist.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/microsoft/PowerToys/issues/comments/1009925228" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u

github-actions · 2022-01-11T13:03:03Z

@check-spelling-bot Report

🔴 Please review

See the files view or the action log for details.

Unrecognized words (5)

childs
Hostbackdropbrush
leaszt
Tickness
Visibel

Previously acknowledged words that are now absent

ChaseKnowlden CleanCodeDeveloper CTLCOLORSTATIC Deuchert efgh errc Grayscale iccex ICONINFORMATION INITCOMMONCONTROLSEX INSTALLLOGATTRIBUTES INSTALLLOGMODE INSTALLUILEVEL MAINICON MAKELPARAM msiexec MSIINSTALLER NATIVEFNTCTL netlify Qin rdeveen rexit SETRANGE SETSTEP sregex STEPIT symlink UITo We'd

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the [email protected]:htcfreek/PowerToys.git repository
on the PT_ImproveWwNew branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/whitelist.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/microsoft/PowerToys/issues/comments/1009943535" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u

github-actions · 2022-01-11T13:28:24Z

@check-spelling-bot Report

🔴 Please review

See the files view or the action log for details.

Unrecognized words (7)

childs
Hostbackdropbrush
invisble
leaszt
thet
Tickness
Visibel

Previously acknowledged words that are now absent

ChaseKnowlden CleanCodeDeveloper CTLCOLORSTATIC Deuchert efgh errc Grayscale iccex ICONINFORMATION INITCOMMONCONTROLSEX INSTALLLOGATTRIBUTES INSTALLLOGMODE INSTALLUILEVEL MAINICON MAKELPARAM msiexec MSIINSTALLER NATIVEFNTCTL netlify Qin rdeveen rexit SETRANGE SETSTEP sregex STEPIT symlink UITo We'd

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the [email protected]:htcfreek/PowerToys.git repository
on the PT_ImproveWwNew branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/whitelist.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/microsoft/PowerToys/issues/comments/1009964777" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u

github-actions · 2022-01-11T14:34:49Z

@check-spelling-bot Report

🔴 Please review

See the files view or the action log for details.

Unrecognized words (1)

instantiable

Previously acknowledged words that are now absent

ChaseKnowlden CleanCodeDeveloper CTLCOLORSTATIC Deuchert efgh errc Grayscale iccex ICONINFORMATION INITCOMMONCONTROLSEX INSTALLLOGATTRIBUTES INSTALLLOGMODE INSTALLUILEVEL MAINICON MAKELPARAM msiexec MSIINSTALLER NATIVEFNTCTL netlify Qin rdeveen rexit SETRANGE SETSTEP sregex STEPIT symlink UITo We'd

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the [email protected]:htcfreek/PowerToys.git repository
on the PT_ImproveWwNew branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/whitelist.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/microsoft/PowerToys/issues/comments/1010023560" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n)+)\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u

src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/WindowProcess.cs

htcfreek · 2022-01-23T13:19:44Z

@davidegiacometti
Can you please take a last look on the code before I mark this PR as ready to review. Thank you.

davidegiacometti · 2022-01-23T17:33:22Z

Will review later

davidegiacometti

LGTM! Tested and working as expected.

crutkas · 2022-01-24T17:05:07Z

@jaimecbernardo can someone look at this?

jaimecbernardo

LGTM!
Great work here!

jaimecbernardo · 2022-01-24T18:46:34Z

Just waiting for a second pair of eyes from @yuyoyuppe and then this can go in.

htcfreek · 2022-01-24T18:54:10Z

@jaimecbernardo
Should I add a sentence to devdocs why we have the event handler in main method? I can do this in the next PR when adding the context menu.

(I personally think we don't need this event handler and can remove it.)

jaimecbernardo · 2022-01-24T19:44:27Z

@jaimecbernardo Should I add a sentence to devdocs why we have the event handler in main method? I can do this in the next PR when adding the context menu.

(I personally think we don't need this event handler and can remove it.)

I'm OK with removing it if you think it's not needed. (pending review, of course, would need to consider the implications)

… into PT_ImproveWwNew

htcfreek · 2022-01-24T21:42:41Z

@jaimecbernardo Should I add a sentence to devdocs why we have the event handler in main method? I can do this in the next PR when adding the context menu.
(I personally think we don't need this event handler and can remove it.)

I'm OK with removing it if you think it's not needed. (pending review, of course, would need to consider the implications)

Obsolete code is removed. PR is ready. 🚀
Let's wait for the review form @yuyoyuppe and then merge it in (for 0.55.0).

yuyoyuppe

The code looks good to me!

)

Import files from old PR microsoft#15329

12f1338

Improvements

6c37d13

htcfreek added 2 commits January 11, 2022 14:26

hide uwp non-windows (microsoft#13637)

e29cc82

update debug tool tip

fd2a719

htcfreek added 5 commits January 11, 2022 14:45

fix spelling and comments

5d58d32

disable tool tip

552fefc

fix doc links

eb00d6d

remove obsolete using

49df906

Update docs

6264e11

fix spelling

6f1e89f

htcfreek self-assigned this Jan 11, 2022

htcfreek marked this pull request as ready for review January 11, 2022 15:14

htcfreek requested review from crutkas, davidegiacometti, yuyoyuppe and franky920920 January 11, 2022 15:14

htcfreek commented Jan 11, 2022

View reviewed changes

src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/WindowProcess.cs Outdated Show resolved Hide resolved

htcfreek mentioned this pull request Jan 11, 2022

[Run][New Plugin] Allow to terminate the selected running process #6084

Closed

davidegiacometti reviewed Jan 12, 2022

View reviewed changes

src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/WindowProcess.cs Outdated Show resolved Hide resolved

htcfreek changed the title ~~[PT Run] WindowWalker: Refactor code, fix some bugs, hide UWP non-windows~~ [PT Run] WindowWalker: Refactor code, fix some bugs, hide UWP non-windows, prepare code for new features Jan 23, 2022

disable debug tool tip

dbd9a6d

htcfreek requested a review from davidegiacometti January 23, 2022 13:18

Update devdocs

f56e8e0

davidegiacometti approved these changes Jan 23, 2022

View reviewed changes

htcfreek marked this pull request as ready for review January 23, 2022 20:27

htcfreek requested review from crutkas and removed request for crutkas January 23, 2022 20:32

jaimecbernardo self-requested a review January 24, 2022 18:16

jaimecbernardo approved these changes Jan 24, 2022

View reviewed changes

htcfreek added 4 commits January 24, 2022 22:23

Merge branch 'microsoft:main' into PT_ImproveWwNew

20c15e2

remove obsolete event handler

80a456c

Merge branch 'PT_ImproveWwNew' of https://github.com/htcfreek/PowerToys…

61170c7

… into PT_ImproveWwNew

update var name

bbfb538

htcfreek requested a review from jaimecbernardo January 24, 2022 21:40

htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Jan 24, 2022

yuyoyuppe approved these changes Jan 25, 2022

View reviewed changes

crutkas merged commit edc43e3 into microsoft:main Jan 25, 2022

htcfreek deleted the PT_ImproveWwNew branch January 25, 2022 09:54

This was referenced Feb 1, 2022

[PT Run] WindowWalker: Temporary remove IsCloaked check #15943

Merged

ApplicationFrameHost.exe in PowerToys Run always, even when no UWP windows are open #13637

Closed

taooceros added a commit to taooceros/Flow.Plugin.WindowWalker that referenced this pull request Jul 13, 2022

Hide preloaded uwp app with cloak state check (microsoft/PowerToys#15441

0464b84

)

taooceros mentioned this pull request Jul 13, 2022

Hide preloaded uwp app with cloak state check taooceros/Flow.Plugin.WindowWalker#32

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PT Run] WindowWalker: Refactor code, fix some bugs, hide UWP non-windows, prepare code for new features #15441

[PT Run] WindowWalker: Refactor code, fix some bugs, hide UWP non-windows, prepare code for new features #15441

htcfreek commented Jan 11, 2022 •

edited

Loading

github-actions bot commented Jan 11, 2022 •

edited

Loading

github-actions bot commented Jan 11, 2022 •

edited

Loading

github-actions bot commented Jan 11, 2022 •

edited

Loading

github-actions bot commented Jan 11, 2022 •

edited

Loading

htcfreek commented Jan 23, 2022

davidegiacometti commented Jan 23, 2022

davidegiacometti left a comment

crutkas commented Jan 24, 2022

jaimecbernardo left a comment

jaimecbernardo commented Jan 24, 2022

htcfreek commented Jan 24, 2022

jaimecbernardo commented Jan 24, 2022

htcfreek commented Jan 24, 2022

yuyoyuppe left a comment

[PT Run] WindowWalker: Refactor code, fix some bugs, hide UWP non-windows, prepare code for new features #15441

[PT Run] WindowWalker: Refactor code, fix some bugs, hide UWP non-windows, prepare code for new features #15441

Conversation

htcfreek commented Jan 11, 2022 • edited Loading

Summary of the Pull Request

How does someone test / validate:

Screenshots:

Quality Checklist

Contributor License Agreement (CLA)

github-actions bot commented Jan 11, 2022 • edited Loading

@check-spelling-bot Report

🔴 Please review

Unrecognized words (3)

github-actions bot commented Jan 11, 2022 • edited Loading

@check-spelling-bot Report

🔴 Please review

Unrecognized words (5)

github-actions bot commented Jan 11, 2022 • edited Loading

@check-spelling-bot Report

🔴 Please review

Unrecognized words (7)

github-actions bot commented Jan 11, 2022 • edited Loading

@check-spelling-bot Report

🔴 Please review

Unrecognized words (1)

htcfreek commented Jan 23, 2022

davidegiacometti commented Jan 23, 2022

davidegiacometti left a comment

Choose a reason for hiding this comment

crutkas commented Jan 24, 2022

jaimecbernardo left a comment

Choose a reason for hiding this comment

jaimecbernardo commented Jan 24, 2022

htcfreek commented Jan 24, 2022

jaimecbernardo commented Jan 24, 2022

htcfreek commented Jan 24, 2022

yuyoyuppe left a comment

Choose a reason for hiding this comment

htcfreek commented Jan 11, 2022 •

edited

Loading

github-actions bot commented Jan 11, 2022 •

edited

Loading

github-actions bot commented Jan 11, 2022 •

edited

Loading

github-actions bot commented Jan 11, 2022 •

edited

Loading

github-actions bot commented Jan 11, 2022 •

edited

Loading