Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT Run] WindowWalker: Temporary remove IsCloaked check #15943

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Feb 1, 2022

Summary of the Pull Request

What is this about:

With #15441 I have implemented a check for the DWM property IsCloaked to hide invisible uwp app windows (#13637). After the change, all windows assigned to a virtual desktop that is not the current visible one aren't listed in the results anymore.

What is included in the PR:

This PR removes the check for IsCloaked property temporary until I have implement an improved version of the check.

How does someone test / validate:

Tested the behavior.

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@htcfreek htcfreek self-assigned this Feb 1, 2022
@htcfreek htcfreek added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Severity-Regression This was working in a previous release labels Feb 1, 2022
@htcfreek
Copy link
Collaborator Author

htcfreek commented Feb 1, 2022

@crutkas
Do you like me to reopen the original issue #13637? Can be released in the hotfix.

@htcfreek htcfreek marked this pull request as ready for review February 1, 2022 22:46
@crutkas
Copy link
Member

crutkas commented Feb 1, 2022

I'd comment in the old issue once the hotfix goes out that this caused a regression and then point to the bug issue and treat that as proper implementation.

@crutkas crutkas added the Hot Fix Items we will product an out-of-band release for label Feb 1, 2022
Copy link
Collaborator

@davidegiacometti davidegiacometti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaimecbernardo jaimecbernardo merged commit 79c13ae into microsoft:main Feb 2, 2022
@htcfreek
Copy link
Collaborator Author

htcfreek commented Feb 2, 2022

@crutkas
Isn't this part of the hotfix or do you missed to mention it in the release notes?

@crutkas
Copy link
Member

crutkas commented Feb 2, 2022

I didn’t see it in stable

@crutkas
Copy link
Member

crutkas commented Feb 2, 2022

Clearly trying to do a change log with GitHub having issues sucks.

@crutkas
Copy link
Member

crutkas commented Feb 2, 2022

Updated change notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hot Fix Items we will product an out-of-band release for Product-PowerToys Run Improved app launch PT Run (Win+R) Window Severity-Regression This was working in a previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants