Launcher does not open files in system that are not in english #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way windows works in systems that are not in english, launcher was trying to open localized paths instead of the real path.s File explorer can translate them to the "real path" but Proccess.Start doesn't do that.
PR Checklist
When Microsoft.Plugin.Indexer is querying it is selecting the System.ItemPathDisplay that returns the localized path of the file/folder. For some reason Proccess.Start does not like localized paths i supposed that is the same reason why powershell does not let me launch localized paths.
Detailed Description of the Pull Request:
I changed System.ItemPathDisplay to System.ItemUrl and remove the scheme from the url during the ExecuteQuery.
Validation Steps Performed
Launch Powertoys Run and search for a file or folder.
Files appear as they should with icons and all actions work.